pkg/littlefs*: align readdir() with documentation#17623
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Feb 8, 2022
Merged
pkg/littlefs*: align readdir() with documentation#17623benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
`readdir()` should only output the name of the file, but littleFS
adds a leading `/`.
Neither FAT nor Linux will exhibit this behavior.
struct dirent *entry;
DIR *dir = opendir(".");
while ((entry = readdir(dir))) {
printf("%s\n", entry->d_name);
}
This results in surprising failures of code that expects filenames
to match that was tested on a different FS, when suddenly there is
a `/` in front of the filename.
benpicco
added
the
Type: bug
benpicco
added
the
CI: ready for build
benpicco
requested review from
MichelRottleuthner,
aabadie,
leandrolanzieri and
smlng
as code owners
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
readdir()should only output the name of the file, but littleFS adds a leading/.Neither FAT nor Linux will exhibit this behavior. (SPIFFS does not support directories)
This results in surprising failures of code that expects filenames to match that was tested on a different FS, when suddenly there is a
/in front of the filename.Testing procedure
before
with this patch
Issues/PRs references