Skip to content

sys/evtimer: use now returned by set#17394

Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_evtimer_now_ztimer
Dec 15, 2021
Merged

sys/evtimer: use now returned by set#17394
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_evtimer_now_ztimer

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Dec 14, 2021 •
edited
Loading

Contribution description

With #17385 a call to ztimer_now can be saved.

Testing procedure

USEMODULE=evtimer_on_ztimer BOARD=<some board> make -C tests/evtimer_msg/ flash test still passes

Issues/PRs references

Found on #17357.

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Dec 14, 2021
@fjmolinas fjmolinas requested a review from kaspar030 December 14, 2021 12:26
@github-actions github-actions bot added Area: sys Area: System Area: timers Area: timer subsystems labels Dec 14, 2021
kaspar030
kaspar030 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 mentioned this pull request Dec 14, 2021
Merged
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Dec 14, 2021

All tests passed, the build failure seems unrealted:

-- running on worker mobi6.inet.haw-hamburg.de-12 thread 1, build number 119978.
make: Entering directory '/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/tests/driver_mag3110'
rm -rf /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg-build/esp8266_sdk
make: Leaving directory '/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/tests/driver_mag3110'
make: Entering directory '/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/tests/driver_mag3110'
[INFO] cloning esp8266_sdk
Building application "tests_driver_mag3110" for "esp8266-esp-12x" with MCU "esp8266".

git-cache: cloning from cache. tag=commit913a06a9ac3b2f18009e8fee8f092ca9ffeccd38-1784034
[INFO] updating esp8266_sdk /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
echo 913a06a9ac3b2f18009e8fee8f092ca9ffeccd38 > /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
[INFO] patch esp8266_sdk
   text	   data	    bss	    dec	    hex	filename
 281468	   5272	  28720	 315460	  4d044	/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/tests_driver_mag3110.elf
esptool.py v2.4.0
Parsing CSV input...
sha1sum /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/tests_driver_mag3110.elf /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/tests_driver_mag3110.elf.bin /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/partitions.bin > /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/test-input-hash.sha1
make: Leaving directory '/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/tests/driver_mag3110'
make: Entering directory '/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/tests/driver_mag3110'
Building application "tests_driver_mag3110" for "esp8266-esp-12x" with MCU "esp8266".

rm -rf /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg-build/esp8266_sdk
[INFO] cloning esp8266_sdk
git-cache: cloning from cache. tag=commit913a06a9ac3b2f18009e8fee8f092ca9ffeccd38-1785114
[INFO] updating esp8266_sdk /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
echo 913a06a9ac3b2f18009e8fee8f092ca9ffeccd38 > /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
[INFO] patch esp8266_sdk
   text	   data	    bss	    dec	    hex	filename
 281692	   5272	  28720	 315684	  4d124	/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/tests_driver_mag3110.elf
esptool.py v2.4.0
Parsing CSV input...
sha1sum /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/tests_driver_mag3110.elf /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/tests_driver_mag3110.elf.bin /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/partitions.bin > /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/test-input-hash.sha1
make: Leaving directory '/tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/tests/driver_mag3110'
Hashes of binaries with and without Kconfig mismatch for tests/driver_mag3110
Please check that all used modules are modelled in Kconfig and enabled
rm -rf /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg-build/esp8266_sdk
rm -rf /tmp/dwq.0.5552209759018482/53cb2d01cbbbd37a4becd36477500b45/build/pkg-build/esp8266_sdk
-- build directory size: 92K

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 14, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Dec 15, 2021

Unrelated CI failure:

-- running on worker mobi6.inet.haw-hamburg.de-10 thread 1, build number 134539.
make: Entering directory '/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux'
rm -rf /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg-build/esp8266_sdk
make: Leaving directory '/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux'
make: Entering directory '/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux'
[INFO] cloning esp8266_sdk
Building application "tests_cb_mux" for "esp8266-esp-12x" with MCU "esp8266".

git-cache: cloning from cache. tag=commit913a06a9ac3b2f18009e8fee8f092ca9ffeccd38-126237
[INFO] updating esp8266_sdk /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
echo 913a06a9ac3b2f18009e8fee8f092ca9ffeccd38 > /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
[INFO] patch esp8266_sdk
   text	   data	    bss	    dec	    hex	filename
 277836	   5292	  28656	 311784	  4c1e8	/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/tests_cb_mux.elf
esptool.py v2.4.0
Parsing CSV input...
sha1sum /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux/tests/01-run.py /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/tests_cb_mux.elf /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/tests_cb_mux.elf.bin /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/partitions.bin > /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/test-input-hash.sha1
make: Leaving directory '/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux'
make: Entering directory '/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux'
Building application "tests_cb_mux" for "esp8266-esp-12x" with MCU "esp8266".
rm -rf /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg-build/esp8266_sdk

[INFO] cloning esp8266_sdk
git-cache: cloning from cache. tag=commit913a06a9ac3b2f18009e8fee8f092ca9ffeccd38-127336
[INFO] updating esp8266_sdk /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
echo 913a06a9ac3b2f18009e8fee8f092ca9ffeccd38 > /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
[INFO] patch esp8266_sdk
   text	   data	    bss	    dec	    hex	filename
 277948	   5292	  28656	 311896	  4c258	/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/tests_cb_mux.elf
esptool.py v2.4.0
Parsing CSV input...
sha1sum /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux/tests/01-run.py /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/tests_cb_mux.elf /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/tests_cb_mux.elf.bin /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/partitions.bin > /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/test-input-hash.sha1
make: Leaving directory '/tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/tests/cb_mux'
Hashes of binaries with and without Kconfig mismatch for tests/cb_mux
Please check that all used modules are modelled in Kconfig and enabled
rm -rf /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg-build/esp8266_sdk
rm -rf /tmp/dwq.0.31996340194084216/e815efea9d40933a9e47a14855ee85b5/build/pkg-build/esp8266_sdk
-- build directory size: 92K

@fjmolinas fjmolinas merged commit e2608e1 into RIOT-OS:master Dec 15, 2021
@fjmolinas fjmolinas deleted the pr_evtimer_now_ztimer branch December 15, 2021 11:11
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

No one assigned

Labels

Area: sys Area: System Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

2 participants

@fjmolinas @kaspar030