sys/ztimer: ztimer_set() return the now value#17385
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Dec 13, 2021
Merged
Conversation
github-actions
bot
added
Area: sys
kaspar030
reviewed
Dec 13, 2021
kaspar030
reviewed
Dec 13, 2021
kaspar030
changed the title
Contributor
|
Make mental note: do the same for ztimer64 |
fjmolinas
added
the
Process: API change
Contributor
|
BTW, does |
Contributor
|
please squash! |
fjmolinas
force-pushed
the
pr_ztimer_set_now
branch
from
0696591 to
2835b6d
Compare
fjmolinas
added
the
CI: ready for build
fjmolinas
force-pushed
the
pr_ztimer_set_now
branch
from
2835b6d to
dd03d8c
Compare
maribu
reviewed
Dec 13, 2021
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
Sorry for being late to the party. But the current CI queue says there would be still 13 minutes left to squash in this nitpick without wasting CI time :) (I'm not insisting on this, but I do like it when all CI tools are happy.)
kaspar030
reviewed
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR makes
ztimer_setreturn thenowvalue it was set against. This change although an API change should not break anything since the function was returning void, but it should allow estimating the actual value against which the set function was used.My main motivation for this is that
esptimer implementation sets atimer_expirevalue that cant be directly translated fromztimertoxtimer. So I'm open to any other better suggestion on doing such a thing.Testing procedure
everything should still build ok!