gnrc/netif: convert to ztimer by bergzand · Pull Request #17354 · RIOT-OS/RIOT

bergzand · 2021-12-08T09:59:43Z

Contribution description

This converts gnrc_netif.c to use ztimer instead of xtimer.

Testing procedure

I think the test in tests tests/gnrc_netif_ipv6_wait_for_global_address should be sufficient:

koen@zometeen ~/dev/RIOT-dev $ make -C tests/gnrc_netif_ipv6_wait_for_global_address/ term
make: Entering directory '/home/koen/dev/RIOT-dev/tests/gnrc_netif_ipv6_wait_for_global_address'
/home/koen/dev/RIOT-dev/tests/gnrc_netif_ipv6_wait_for_global_address/bin/native/tests_gnrc_netif_ipv6_wait_for_global_address.elf /dev/ttyACM0 
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
s
START
....
OK (4 tests)

Issues/PRs references

On the list of #17111

fjmolinas

Some comments...

sys/net/gnrc/Makefile.dep

tests/ztimer_overhead/Makefile

fjmolinas · 2021-12-08T12:23:16Z

Please squash!

bergzand · 2021-12-08T12:26:18Z

Please squash!

squashed!

fjmolinas

ACK, straightforward enough, ran the test on multiple BOARDs all passing.

I had testted on the wrong branch

fjmolinas · 2021-12-08T19:22:56Z

There seems to be an issue, the test does not pass on frdm-kw41z, did on master, it simply stalls

fjmolinas · 2022-01-28T12:25:48Z

There seems to be an issue, the test does not pass on frdm-kw41z, did on master, it simply stalls

This issue was fixed with #17393

fjmolinas

re-ACK @bergzand can you push a commit adding the required BOARDs to Makefile.ci, since this one is a bit old, could you rebase as well?

fjmolinas · 2022-01-28T13:02:00Z

examples/ccn-lite-relay/Makefile.ci

@@ -1,3 +1,4 @@
 BOARD_INSUFFICIENT_MEMORY := \
    stm32f030f4-demo \
+    pba-d-01-kw2x \


Are you sure this is needed?

BOARD=pba-d-01-kw2x make -C examples/ccn-lite-relay/ -j Building application "ccn-lite-relay" for "pba-d-01-kw2x" with MCU "kinetis". "make" -C /home/francisco/workspace/RIOT/pkg/ccn-lite /home/francisco/workspace/RIOT/dist/tools/cmake/generate-xcompile-toolchain.sh > /home/francisco/workspace/RIOT/build/pkg/ccn-lite/xcompile-toolchain.cmake cmake -B/home/francisco/workspace/RIOT/examples/ccn-lite-relay/bin/pba-d-01-kw2x/pkg-build/ccn-lite -H/home/francisco/workspace/RIOT/build/pkg/ccn-lite/src \ -DCMAKE_TOOLCHAIN_FILE=/home/francisco/workspace/RIOT/build/pkg/ccn-lite/xcompile-toolchain.cmake \ -DCCNL_RIOT=1 -DRIOT_CFLAGS="-isystem /home/francisco/opt/gcc-arm-none-eabi-10-2020-q4-major/arm-none-eabi/include/newlib-nano -I/home/francisco/workspace/RIOT/core/include -I/home/francisco/workspace/RIOT/drivers/include -I/home/francisco/workspace/RIOT/sys/include -I/home/francisco/workspace/RIOT/boards/pba-d-01-kw2x/include -I/home/francisco/workspace/RIOT/cpu/kinetis/include -I/home/francisco/workspace/RIOT/cpu/cortexm_common/include -I/home/francisco/workspace/RIOT/cpu/cortexm_common/include/vendor -I/home/francisco/workspace/RIOT/sys/libc/include -I/home/francisco/workspace/RIOT/build/pkg/ccn-lite/src/ccnl-riot/include -I/home/francisco/workspace/RIOT/build/pkg/ccn-lite/src/ccnl-core/include -I/home/francisco/workspace/RIOT/build/pkg/ccn-lite/src/ccnl-pkt/include -I/home/francisco/workspace/RIOT/build/pkg/ccn-lite/src/ccnl-fwd/include -I/home/francisco/workspace/RIOT/sys/net/gnrc/pktbuf/include -I/home/francisco/workspace/RIOT/sys/net/gnrc/pktbuf_static/include -I/home/francisco/workspace/RIOT/sys/posix/include -I/home/francisco/workspace/RIOT/sys/net/link_layer/eui_provider/include -I/home/francisco/workspace/RIOT/drivers/kw2xrf/include" -DBUILD_TESTING=OFF Doxygen build started -- Configuring done -- Generating done -- Build files have been written to: /home/francisco/workspace/RIOT/examples/ccn-lite-relay/bin/pba-d-01-kw2x/pkg-build/ccn-lite make -C /home/francisco/workspace/RIOT/examples/ccn-lite-relay/bin/pba-d-01-kw2x/pkg-build/ccn-lite [ 11%] Built target ccnl-pkt [ 13%] Built target ccnl-fwd [ 48%] Built target ccnl-core [100%] Built target ccnl-riot "make" -C /home/francisco/workspace/RIOT/boards/pba-d-01-kw2x "make" -C /home/francisco/workspace/RIOT/core "make" -C /home/francisco/workspace/RIOT/cpu/kinetis "make" -C /home/francisco/workspace/RIOT/drivers "make" -C /home/francisco/workspace/RIOT/sys "make" -C /home/francisco/workspace/RIOT/drivers/kw2xrf "make" -C /home/francisco/workspace/RIOT/drivers/netdev "make" -C /home/francisco/workspace/RIOT/sys/auto_init "make" -C /home/francisco/workspace/RIOT/drivers/periph_common "make" -C /home/francisco/workspace/RIOT/sys/div "make" -C /home/francisco/workspace/RIOT/cpu/cortexm_common "make" -C /home/francisco/workspace/RIOT/sys/evtimer "make" -C /home/francisco/workspace/RIOT/cpu/kinetis/periph "make" -C /home/francisco/workspace/RIOT/sys/fmt "make" -C /home/francisco/workspace/RIOT/sys/frac "make" -C /home/francisco/workspace/RIOT/sys/isrpipe "make" -C /home/francisco/workspace/RIOT/sys/luid "make" -C /home/francisco/workspace/RIOT/sys/malloc_thread_safe "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc "make" -C /home/francisco/workspace/RIOT/sys/net/link_layer/eui_provider "make" -C /home/francisco/workspace/RIOT/sys/net/link_layer/ieee802154 "make" -C /home/francisco/workspace/RIOT/sys/net/link_layer/l2util "make" -C /home/francisco/workspace/RIOT/cpu/cortexm_common/periph "make" -C /home/francisco/workspace/RIOT/sys/net/netif "make" -C /home/francisco/workspace/RIOT/sys/newlib_syscalls_default "make" -C /home/francisco/workspace/RIOT/sys/od "make" -C /home/francisco/workspace/RIOT/sys/pm_layered "make" -C /home/francisco/workspace/RIOT/sys/ps "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/netapi "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/netif "make" -C /home/francisco/workspace/RIOT/sys/random "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/netreg "make" -C /home/francisco/workspace/RIOT/sys/shell "make" -C /home/francisco/workspace/RIOT/sys/shell/commands "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/pkt "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/pktbuf "make" -C /home/francisco/workspace/RIOT/sys/stdio_uart "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/pktbuf_static "make" -C /home/francisco/workspace/RIOT/sys/timex "make" -C /home/francisco/workspace/RIOT/sys/tsrb "make" -C /home/francisco/workspace/RIOT/sys/ztimer "make" -C /home/francisco/workspace/RIOT/sys/ztimer64 "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/pktdump "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/netif/hdr "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/netif/ieee802154 "make" -C /home/francisco/workspace/RIOT/sys/net/gnrc/netif/init_devs text data bss dec hex filename 62660 180 14848 77688 12f78 /home/francisco/workspace/RIOT/examples/ccn-lite-relay/bin/pba-d-01-kw2x/ccn-lite-relay.elf

Oops, fixed with the latests push

fjmolinas · 2022-01-31T08:42:36Z

Thanks @bergzand!

bergzand requested review from MichelRottleuthner, PeterKietzmann, aabadie, cgundogan, fjmolinas, haukepetersen, leandrolanzieri, miri64 and smlng as code owners December 8, 2021 09:59

github-actions bot added Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Dec 8, 2021

bergzand mentioned this pull request Dec 8, 2021

[TRACKING]: ztimer migration issues #17111

Open

22 tasks

fjmolinas reviewed Dec 8, 2021

View reviewed changes

sys/net/gnrc/Makefile.dep Show resolved Hide resolved

tests/ztimer_overhead/Makefile Outdated Show resolved Hide resolved

bergzand force-pushed the pr/gnrc_netif/ztimer branch from d02aea1 to 2304ac3 Compare December 8, 2021 12:26

fjmolinas previously approved these changes Dec 8, 2021

View reviewed changes

fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 8, 2021

fjmolinas enabled auto-merge December 8, 2021 19:19

fjmolinas disabled auto-merge December 8, 2021 19:21

fjmolinas approved these changes Jan 28, 2022

View reviewed changes

bergzand added 2 commits January 28, 2022 13:38

gnrc/netif: convert to ztimer

3b5662e

tests/gnrc_netif_ipv6_wait_for_global_address: convert to ztimer

fe0b297

bergzand force-pushed the pr/gnrc_netif/ztimer branch from 2304ac3 to fe0b297 Compare January 28, 2022 12:39

github-actions bot added the Area: examples Area: Example Applications label Jan 28, 2022

fjmolinas reviewed Jan 28, 2022

View reviewed changes

tests/drivers_at86rf215: Exclude z1

93ac9d9

bergzand force-pushed the pr/gnrc_netif/ztimer branch from 78594a4 to 93ac9d9 Compare January 28, 2022 13:04

github-actions bot removed the Area: examples Area: Example Applications label Jan 28, 2022

fjmolinas merged commit ba325e8 into RIOT-OS:master Jan 31, 2022

bergzand deleted the pr/gnrc_netif/ztimer branch January 31, 2022 09:38

OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gnrc/netif: convert to ztimer#17354

gnrc/netif: convert to ztimer#17354
fjmolinas merged 3 commits intoRIOT-OS:masterfrom
bergzand:pr/gnrc_netif/ztimer

bergzand commented Dec 8, 2021

Uh oh!

fjmolinas left a comment

Uh oh!

Uh oh!

Uh oh!

fjmolinas commented Dec 8, 2021

Uh oh!

bergzand commented Dec 8, 2021

Uh oh!

fjmolinas left a comment

Uh oh!

fjmolinas commented Dec 8, 2021

Uh oh!

fjmolinas commented Jan 28, 2022

Uh oh!

fjmolinas left a comment

Uh oh!

fjmolinas Jan 28, 2022

Uh oh!

bergzand Jan 28, 2022

Uh oh!

fjmolinas commented Jan 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bergzand commented Dec 8, 2021

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fjmolinas commented Dec 8, 2021

Uh oh!

bergzand commented Dec 8, 2021

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

fjmolinas commented Dec 8, 2021

Uh oh!

fjmolinas commented Jan 28, 2022

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

fjmolinas Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

bergzand Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

fjmolinas commented Jan 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants