sys/{x,z}timer/Kconfig: fix compatibility modules#17160
sys/{x,z}timer/Kconfig: fix compatibility modules#17160leandrolanzieri wants to merge 2 commits intoRIOT-OS:masterfrom
Conversation
leandrolanzieri
added
the
Type: bug
github-actions
bot
added
Area: Kconfig
MrKevinWeiss
added
the
CI: ready for build
|
Murdock seems not to like this (yet), is that expected? |
Nope, let's see now |
|
Is this obsolete now or just needs a rebase? |
| menuconfig MODULE_XTIMER | ||
| bool "xtimer" | ||
| depends on HAS_PERIPH_TIMER || MODULE_XTIMER_ON_ZTIMER || MODULE_ZTIMER_XTIMER_COMPAT | ||
| depends on HAS_PERIPH_TIMER |
There was a problem hiding this comment.
Note that ZTIMER_USEC could be provided by other timers than periph_timer as well. E.g. the periph_ptp would be one option, but it should be possible (even though likely not too sensible) to also run ZTIMER_USEC on top of an RTT. (Some applications will not behave well when the resolution of ZTIMER_USEC is > 30 us, though.)
If there is an easy fix to not depend on periph_timer when ztimer is as backend, this would be nice. Otherwise, I think this should get in as is and we should focus on getting rid of xtimer for good.
There was a problem hiding this comment.
Hmm I see, ok I'll try to look into this, but I'm suspecting such behaviour could end up again in a loop.
There was a problem hiding this comment.
This is really a niche scenario and xtimer is not going to stay, anyway. So I wouldn't spend more than 5 minutes on this, if I were in your shoes ;-)
This should be no longer needed. We can close. |
|
#17165 solved this |
4 participants
Contribution description
Currently the xtimer/ztimer compatibility modules choice was optional in Kconfig, but we want one to be enabled when ztimer is selected.
Testing procedure
Issues/PRs references
Pointed out in #17137