driver/at30tse75x: port to ztimer_usec by kfessel · Pull Request #17137 · RIOT-OS/RIOT

kfessel · 2021-11-04T13:24:04Z

Contribution description

port at30tse75x-driver to ztimer_usec

Testing procedure

build and run tests/at30tse75x-driver

Issues/PRs references

aabadie · 2021-11-04T13:41:09Z

If you want to test on hardware, this sensor is available on the samr21-xpro boards provided by IoT-LAB (Saclay site only), see https://www.iot-lab.info/docs/boards/microchip-samr21/

tests/test_interactive.config

kfessel · 2021-11-04T17:21:36Z

@aabadie: I neither can get the master nor the PR working on the iot-lab.info. I get

at30tse75x init 0
Error initializing AT30TSE75x sensor on I2C #0 @ 0x48

in both cases

kfessel · 2021-11-04T22:34:04Z

@aabadie: test worked the senor is at 0x4f (riot defaults to 0x48)->

main(): This is RIOT! (Version: 2021.10-devel-1178-g1ebd4-p-ztimer-at30tse75x)
AT30TSE75x device driver test
> at30tse75x init 0 0x4f
at30tse75x init 0 0x4f
Initialized AT30TSE75x sensor on I2C #0 @ 0x4f
> at30tse75x read
at30tse75x read
Temperature: 20.500 °C

maybe you are able to change the link to the in the iot-lab documentation to the Microchip IO1 Xplained extension doc mentation is wrong maybe microchips own docu is the right choice

aabadie · 2021-11-05T08:13:20Z

You forgot to adapt the module dependencies in Kconfig

drivers/at30tse75x/Kconfig

fjmolinas · 2021-11-05T10:25:38Z

@aabadie: test worked the senor is at 0x4f (riot defaults to 0x48)->
main(): This is RIOT! (Version: 2021.10-devel-1178-g1ebd4-p-ztimer-at30tse75x)
AT30TSE75x device driver test
> at30tse75x init 0 0x4f
at30tse75x init 0 0x4f
Initialized AT30TSE75x sensor on I2C #0 @ 0x4f
> at30tse75x read
at30tse75x read
Temperature: 20.500 °C
maybe you are able to change the link to the in the iot-lab documentation to the Microchip IO1 Xplained extension doc mentation is wrong maybe microchips own docu is the right choice

Is

RIOT/drivers/io1_xplained/include/io1_xplained_params.h

Lines 37 to 39 in c739516

    
           #ifndef IO1_XPLAINED_PARAM_ADDR 
        
           #define IO1_XPLAINED_PARAM_ADDR   (0x07) 
        
           #endif

correct then?

fjmolinas

Tested, seems to work fine:
BOARD=samr21-xpro make -C tests/driver_io1_xplained/ flash term -j

2021-11-05 11:27:50,172 # SD Card CID info:
2021-11-05 11:27:50,173 # MID: 3
2021-11-05 11:27:50,173 # OID: SD
2021-11-05 11:27:50,173 # PNM: DSU04
2021-11-05 11:27:50,174 # PRV: 128
2021-11-05 11:27:50,174 # PSN: 4012115276
2021-11-05 11:27:50,174 # MDT: 252
2021-11-05 11:27:50,175 # CRC: 177
2021-11-05 11:27:50,175 # +----------------------------------------+
2021-11-05 11:27:50,176 # 
2021-11-05 11:27:51,155 # Light level: 0
2021-11-05 11:27:51,159 # +-------------------------------------+
2021-11-05 11:27:56,196 # Temperature [°C]: 23.312
2021-11-05 11:27:56,200 # +-------------------------------------+
2021-11-05 11:27:57,208 # SD Card CID info:
2021-11-05 11:27:57,209 # MID: 3
2021-11-05 11:27:57,209 # OID: SD
2021-11-05 11:27:57,210 # PNM: DSU04
2021-11-05 11:27:57,211 # PRV: 128
2021-11-05 11:27:57,213 # PSN: 4012115276
2021-11-05 11:27:57,214 # MDT: 252
2021-11-05 11:27:57,214 # CRC: 177
2021-11-05 11:27:57,218 # +----------------------------------------+
2021-11-05 11:27:57,219 # 
2021-11-05 11:27:58,226 # Light level: 0
2021-11-05 11:27:58,230 # +-------------------------------------+
2021-11-05 11:28:03,267 # Temperature [°C]: 23.187
2021-11-05 11:28:03,271 # +-------------------------------------+
2021-11-05 11:28:04,279 # SD Card CID info:
2021-11-05 11:28:04,280 # MID: 3
2021-11-05 11:28:04,281 # OID: SD
2021-11-05 11:28:04,282 # PNM: DSU04
2021-11-05 11:28:04,282 # PRV: 128
2021-11-05 11:28:04,284 # PSN: 4012115276
2021-11-05 11:28:04,285 # MDT: 252
2021-11-05 11:28:04,286 # CRC: 177
2021-11-05 11:28:04,290 # +----------------------------------------+
2021-11-05 11:28:04,290 # 
2021-11-05 11:28:05,298 # Light level: 0
2021-11-05 11:28:05,301 # +-------------------------------------+

kfessel · 2021-11-05T10:46:34Z

Is

RIOT/drivers/io1_xplained/include/io1_xplained_params.h

Lines 37 to 39 in c739516

#ifndef IO1_XPLAINED_PARAM_ADDR

#define IO1_XPLAINED_PARAM_ADDR (0x07)

#endif

correct then?

Yes, I just wasn't using saul which lead me to search ....

fjmolinas

ACK!

kfessel · 2021-11-05T15:31:26Z

https://ci.riot-os.org/RIOT-OS/RIOT/17137/314bc0090278e175705e06910d82f3e40a6d5430/output/compile/tests/driver_io1_xplained/samr21-xpro:gnu.txt

moddif.txt
samr21-xpro gnu.txt

Seems like this rule isn't in KConfig:

RIOT/sys/ztimer/Makefile.dep

Lines 26 to 36 in 314bc00

    
           # unless ztimer_xtimer_compat is used, make xtimer use ztimer_usec as backend. 
        
           ifneq (,$(filter ztimer_periph_timer,$(USEMODULE))) 
        
             ifneq  (,$(filter xtimer,$(USEMODULE))) 
        
               ifeq (,$(filter ztimer_xtimer_compat,$(USEMODULE))) 
        
                 USEMODULE += xtimer_on_ztimer 
        
               endif 
        
             endif 
        
             ifneq (,$(filter evtimer,$(USEMODULE))) 
        
               USEMODULE += evtimer_on_ztimer 
        
             endif 
        
           endif

kfessel · 2021-11-05T16:39:10Z

I am not sure i this is the way i am supposed to solve that (I would think there is some kind of Automatisation to try to get a working configuration for xtimer but it seem like "No")

fjmolinas · 2021-11-05T16:43:16Z

I am not sure i this is the way i am supposed to solve that (I would think there is some kind of Automatisation to try to get a working configuration for xtimer but it seem like "No")

@leandrolanzieri is this one of the corner cases where we match configuration to match in the test application or is it something to be fixed in the modeling?

kfessel · 2021-11-05T16:45:34Z

Every kind of trying to auto select the MODULE_XTIMER_ON_ZTIMER failed due to being a loop. (tryed selects with if depend on, if block that include or remove that choiceblock)

Making the choice (of x_on_z or xtimer_compat) non optional would make it allway include one (even if no one need a xtimer interface)

May be it is just the case that we need more explicit choices with KConfig

leandrolanzieri · 2021-11-08T09:41:32Z

@leandrolanzieri is this one of the corner cases where we match configuration to match in the test application or is it something to be fixed in the modeling?

This should be changed in Kconfig modelling. I'm looking into it to provide a fix.

Making the choice (of x_on_z or xtimer_compat) non optional would make it allway include one (even if no one need a xtimer interface)

Yes, we need to make it non optional but also depend on xtimer being there.

kfessel · 2021-11-11T10:53:09Z

with #17165 in this should work without that last commit

aabadie · 2021-11-11T11:07:27Z

Retested on IoT-LAB and works. ACK

driver/at30tse75x: avoid direct use of xtimer_ticks

4d552e7

github-actions bot added the Area: drivers Area: Device drivers label Nov 4, 2021

kfessel changed the title ~~P ztimer at30tse75x~~ driver/at30tse75x: port to ztimer_usec Nov 4, 2021

kfessel requested review from aabadie and fjmolinas November 4, 2021 13:38

kfessel force-pushed the p-ztimer-at30tse75x branch from b550f14 to e990bb5 Compare November 4, 2021 16:15

kfessel requested review from MichelRottleuthner, leandrolanzieri and smlng as code owners November 4, 2021 16:15

github-actions bot added the Area: tests Area: tests and testing framework label Nov 4, 2021

fjmolinas reviewed Nov 4, 2021

View reviewed changes

tests/test_interactive.config Outdated Show resolved Hide resolved

kfessel force-pushed the p-ztimer-at30tse75x branch from e990bb5 to 95be6bf Compare November 4, 2021 16:56

github-actions bot removed the Area: tests Area: tests and testing framework label Nov 4, 2021

kfessel added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 4, 2021

kfessel requested review from cgundogan and jia200x as code owners November 5, 2021 09:25

github-actions bot added the Area: Kconfig Area: Kconfig integration label Nov 5, 2021

fjmolinas reviewed Nov 5, 2021

View reviewed changes

drivers/at30tse75x/Kconfig Show resolved Hide resolved

fjmolinas reviewed Nov 5, 2021

View reviewed changes

fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 5, 2021

kfessel added 2 commits November 5, 2021 12:19

driver/at30tse75x: port to ztimer_usec

fc8e6f0

driver/at30tse75x: cleanup for static tests

314bc00

kfessel force-pushed the p-ztimer-at30tse75x branch from a5fe74b to 314bc00 Compare November 5, 2021 11:20

kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 5, 2021

fjmolinas approved these changes Nov 5, 2021

View reviewed changes

kfessel removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 5, 2021

aabadie mentioned this pull request Nov 5, 2021

[TRACKING]: ztimer migration issues #17111

Open

22 tasks

github-actions bot added the Area: tests Area: tests and testing framework label Nov 5, 2021

kfessel force-pushed the p-ztimer-at30tse75x branch from f3792bf to 4ebb099 Compare November 5, 2021 16:36

kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 5, 2021

kfessel mentioned this pull request Nov 6, 2021

correct link for Micochip IO1 Xplained extension iot-lab/iot-lab.github.io#4

Merged

This was referenced Nov 8, 2021

sys/{x,z}timer/Kconfig: fix compatibility modules #17160

Closed

sys/ztimer: rework Kconfig #17165

Merged

kfessel force-pushed the p-ztimer-at30tse75x branch from 4ebb099 to 314bc00 Compare November 11, 2021 10:51

github-actions bot removed the Area: tests Area: tests and testing framework label Nov 11, 2021

benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 12, 2021

kfessel merged commit 3d33cee into RIOT-OS:master Nov 12, 2021

fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021

Conversation

kfessel commented Nov 4, 2021

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

aabadie commented Nov 4, 2021

Uh oh!

Uh oh!

kfessel commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kfessel commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented Nov 5, 2021

Uh oh!

Uh oh!

fjmolinas commented Nov 5, 2021

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

kfessel commented Nov 5, 2021

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

kfessel commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kfessel commented Nov 5, 2021

Uh oh!

fjmolinas commented Nov 5, 2021

Uh oh!

kfessel commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leandrolanzieri commented Nov 8, 2021

Uh oh!

kfessel commented Nov 11, 2021

Uh oh!

aabadie commented Nov 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kfessel commented Nov 4, 2021 •

edited

Loading

kfessel commented Nov 4, 2021 •

edited

Loading

kfessel commented Nov 5, 2021 •

edited

Loading

kfessel commented Nov 5, 2021 •

edited

Loading