Skip to content

sys/ztimer: don't default to rtc for ztimer_sec#17113

Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_ztimer_sec_no_rtc
Nov 2, 2021
Merged

sys/ztimer: don't default to rtc for ztimer_sec#17113
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_ztimer_sec_no_rtc

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Nov 2, 2021

Contribution description

As mentioned in #17099 auto-select rtc for ztimer_sec done in #16909 seems to not be a good idea, this reverts that change while still preferring rtt over periph_timer.

Testing procedure

  • green murdock

@fjmolinas fjmolinas requested a review from kfessel November 2, 2021 14:35
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: timers Area: timer subsystems labels Nov 2, 2021
@kfessel kfessel added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 2, 2021
@kfessel
Copy link
Copy Markdown
Contributor

kfessel commented Nov 2, 2021

lets wait for murdock

@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Nov 2, 2021

Is this really a bug?

@kfessel
Copy link
Copy Markdown
Contributor

kfessel commented Nov 2, 2021 •
edited
Loading

I think so, it is not enhancement (more a removal of a disenhancment) it is not a new feature (more a removal ...), i think cleanup also does not apply.
This may very well have resulted in some seriously not performing firmware -> bug.

kfessel
kfessel approved these changes Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fjmolinas fjmolinas merged commit 8e0d5ef into RIOT-OS:master Nov 2, 2021
@fjmolinas fjmolinas deleted the pr_ztimer_sec_no_rtc branch November 2, 2021 21:34
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Nov 2, 2021

Thanks for the review!

@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfessel kfessel kfessel approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

2 participants

@fjmolinas @kfessel