Skip to content

pkg/wakaama: use ztimer#17103

Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pkg/wakaama/use_ztimer
Nov 2, 2021
Merged

pkg/wakaama: use ztimer#17103
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pkg/wakaama/use_ztimer

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Nov 2, 2021

Contribution description

This changes the platform adaption for Wakaama to use ztimer (ZTIMER_SEC) instead of xtimer.

Testing procedure

  • The example application should work as usual. Nodes should update their registration before it expires.

Issues/PRs references

Ticks an item of #13667

@github-actions github-actions bot added the Area: pkg Area: External package ports label Nov 2, 2021
@leandrolanzieri leandrolanzieri added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports and removed Area: pkg Area: External package ports labels Nov 2, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Nov 2, 2021

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 2, 2021

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

The registration lifetime, which currently defaults to 300 seconds (https://doc.riot-os.org/group__lwm2m__client__config.html#gad11a3c875f5a688dad541aca7e137b27)

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Nov 2, 2021

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

The registration lifetime, which currently defaults to 300 seconds (https://doc.riot-os.org/group__lwm2m__client__config.html#gad11a3c875f5a688dad541aca7e137b27)

I can see it updated before expiry but not exactly at 5min, is that a problem?

image

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Nov 2, 2021

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

The registration lifetime, which currently defaults to 300 seconds (https://doc.riot-os.org/group__lwm2m__client__config.html#gad11a3c875f5a688dad541aca7e137b27)

I can see it updated before expiry but not exactly at 5min, is that a problem?

image

Same behaviour in master, so a non-issue.

image

fjmolinas
fjmolinas approved these changes Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Nov 2, 2021

Please rebase once #17104 is in

@fjmolinas fjmolinas mentioned this pull request Nov 2, 2021
Open
22 tasks
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 2, 2021
@fjmolinas fjmolinas merged commit 555c8b2 into RIOT-OS:master Nov 2, 2021
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @fjmolinas