drivers/nrf24l01+ : added low-level functions for nrf24l01+ transceiver by PeterKietzmann · Pull Request #1704 · RIOT-OS/RIOT

PeterKietzmann · 2014-09-24T14:54:24Z

This PR contains multiple low-level functions for the nrf24l01+ driver. Maybe some of them seem useless here but these are interesting when it comes to bind the driver to the general network driver interface, which will be part of another PR soon. Furthermore there are some functions on which I'm not sure if they are necessary. Feel free to discuss :-) !

~~Depends on #1584~~ (merged)

LudwigKnuepfer · 2014-09-24T15:03:01Z

tests/nrf24l01_test_lowlevel/Makefile

haukepetersen · 2014-09-24T15:10:10Z

Looking great! Will test soon.

LudwigKnuepfer · 2014-09-24T15:11:50Z

tests/nrf24l01_test_lowlevel/main.c

I think it might make sense to define these externally in the Makefile.

Hm, I think the Makefile is maybe not the right place because this seems so unfelxible. Correct me if I'm wrong? A comprise could be the definition of e.g. SPI_PORT, CS_PIN, CE_PIN, IRQ_PIN on top of the script, what do you think?

LudwigKnuepfer · 2014-09-26T14:10:59Z

tests/nrf24l01_test_lowlevel/main.c

Now that you un-disabled auto_init this is unnecessary at best.

PeterKietzmann · 2014-09-29T09:02:56Z

I addressed your comments @LudwigOrtmann

LudwigKnuepfer · 2014-09-29T11:25:33Z

Travis says:

$ ./dist/tools/licenses/check.sh master
file has an unknown license header: 'tests/nrf24l01_test_lowlevel/main.c'
The command "./dist/tools/licenses/check.sh master" exited with 1.

LudwigKnuepfer · 2014-09-29T11:33:39Z

drivers/nrf24l01p/nrf24l01p.c

missing newline according to git

LudwigKnuepfer · 2014-09-29T11:41:41Z

You still need to either use auto_init OR initialize vtimer (possibly more, didn't look).

LudwigKnuepfer · 2014-09-30T11:00:50Z

tests/test_spi/main.c

stray blank lines

haukepetersen · 2014-09-30T11:47:35Z

Could you rebase (now that the SPI driver is merged)? Thx!

LudwigKnuepfer · 2014-10-31T13:10:25Z

drivers/include/nrf24l01p.h

Remove the file name, doxygen is better off without it.

PeterKietzmann · 2014-10-31T15:43:01Z

I deleted a blocking while loop and added a delay for the "on-air" transmission after the transmit command. This managed the hanging state on the arduino-due. Also it turned out, that SPI_0 and SPI_1 do not behave exactly similar to each other, regarding timings. Therfore I increased the delays DELAY_CS_TOGGLE_TICKS and DELAY_AFTER_FUNC_TICKS just by one tick and it worked.

PeterKietzmann · 2014-11-25T21:58:06Z

rebased and already squashed

haukepetersen · 2014-11-25T22:08:06Z

RIOT/drivers/Makefile.include:27: *** missing `endif'. Stop.

Da ist dir in der viert letzten Zeile ein endif verloren gegangen...

PeterKietzmann · 2014-11-25T22:17:13Z

Uuuuups, I corrected this

haukepetersen · 2014-11-25T22:38:20Z

No problem. Using and a stm32f4discovery and a stm32f0discovery the test application still crashes. I am not sure, but I suspect the SPI driver for the F0. I will run another test using two stm32f4discoverys once I am back in the office...

PeterKietzmann · 2014-11-26T07:59:51Z

I once had this setup and it worked. However, I'll also try this in this forenoon.

PeterKietzmann · 2014-11-26T11:20:12Z

If you look at 0e8bcff I increased a delay value for this code line so the driver also runs on the stm32f0. On the stm32f4 the driver works fine without this change. However, I think we can live with 10 us longer delay and merge this PR but we should be aware that this has nothing to do with #1956 or similar.

haukepetersen · 2014-11-26T12:48:57Z

Now it works perfectly, very cool! ACK when squashed.

PeterKietzmann · 2014-11-26T12:51:20Z

Squashed

haukepetersen · 2014-11-26T12:57:33Z

and go

drivers/nrf24l01+ : added low-level functions for nrf24l01+ transceiver

OlegHahm · 2014-11-26T13:04:18Z

Hooray!

BytesGalore · 2014-11-26T13:17:03Z

Congrats!

LudwigKnuepfer · 2014-11-26T14:21:40Z

:)

The delays were introduced in an attempt to fix "inexplicable timing errors", although the errors were in the SPI bus driver rather than the nrf24l01p driver. See also: - RIOT-OS#1704 - RIOT-OS#2315 Signed-off-by: Joakim Gebart <[email protected]>

LudwigKnuepfer · 2017-01-14T19:05:12Z

This PR contains multiple low-level functions for the nrf24l01+ driver. Maybe some of them seem useless here but these are interesting when it comes to bind the driver to the general network driver interface, which will be part of another PR soon.

@PeterKietzmann It's been a while - any news?

PeterKietzmann · 2017-01-15T14:09:18Z

Unfortunately not.

PeterKietzmann added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Sep 24, 2014

LudwigKnuepfer reviewed Sep 24, 2014
View reviewed changes

tests/nrf24l01_test_lowlevel/Makefile Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Sep 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

LudwigKnuepfer reviewed Sep 24, 2014
View reviewed changes

LudwigKnuepfer self-assigned this Sep 25, 2014

LudwigKnuepfer reviewed Sep 26, 2014
View reviewed changes

tests/nrf24l01_test_lowlevel/main.c Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Sep 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you un-disabled auto_init this is unnecessary at best.

LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 29, 2014

LudwigKnuepfer reviewed Sep 29, 2014
View reviewed changes

drivers/nrf24l01p/nrf24l01p.c Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Sep 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline according to git

LudwigKnuepfer reviewed Sep 30, 2014
View reviewed changes

tests/test_spi/main.c Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Sep 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray blank lines

PeterKietzmann force-pushed the add_nrf24l01p_lowlevel branch from 8965047 to f1d986f Compare September 30, 2014 12:17

PeterKietzmann removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 30, 2014

PeterKietzmann force-pushed the add_nrf24l01p_lowlevel branch from 4106341 to 3034caa Compare October 31, 2014 12:58

LudwigKnuepfer reviewed Oct 31, 2014
View reviewed changes

drivers/include/nrf24l01p.h Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the file name, doxygen is better off without it.

LudwigKnuepfer added the Area: drivers Area: Device drivers label Oct 31, 2014

PeterKietzmann force-pushed the add_nrf24l01p_lowlevel branch from 6df720d to 154c4e8 Compare November 25, 2014 21:56

PeterKietzmann force-pushed the add_nrf24l01p_lowlevel branch from f2a26c8 to 0e8bcff Compare November 26, 2014 10:58

Initial import of nrf24l01p lowlevel functions

d8a26d5

PeterKietzmann force-pushed the add_nrf24l01p_lowlevel branch from 0946db2 to d8a26d5 Compare November 26, 2014 12:50

haukepetersen added a commit that referenced this pull request Nov 26, 2014

Merge pull request #1704 from PeterKietzmann/add_nrf24l01p_lowlevel

dfabe77

drivers/nrf24l01+ : added low-level functions for nrf24l01+ transceiver

haukepetersen merged commit dfabe77 into RIOT-OS:master Nov 26, 2014

OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Nov 26, 2014

PeterKietzmann mentioned this pull request Jan 16, 2015

drivers/periph/spi: Implement thread safety for all SPI devices #2317

Merged

PeterKietzmann deleted the add_nrf24l01p_lowlevel branch March 26, 2015 08:46

Conversation

PeterKietzmann commented Sep 24, 2014

Uh oh!

LudwigKnuepfer Sep 24, 2014

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Sep 24, 2014

Uh oh!

LudwigKnuepfer Sep 24, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann Sep 25, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Sep 26, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann commented Sep 29, 2014

Uh oh!

LudwigKnuepfer commented Sep 29, 2014

Uh oh!

LudwigKnuepfer Sep 29, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer commented Sep 29, 2014

Uh oh!

LudwigKnuepfer Sep 30, 2014

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Sep 30, 2014

Uh oh!

LudwigKnuepfer Oct 31, 2014

Choose a reason for hiding this comment

Uh oh!

PeterKietzmann commented Oct 31, 2014

Uh oh!

PeterKietzmann commented Nov 25, 2014

Uh oh!

haukepetersen commented Nov 25, 2014

Uh oh!

PeterKietzmann commented Nov 25, 2014

Uh oh!

haukepetersen commented Nov 25, 2014

Uh oh!

PeterKietzmann commented Nov 26, 2014

Uh oh!

PeterKietzmann commented Nov 26, 2014

Uh oh!

haukepetersen commented Nov 26, 2014

Uh oh!

PeterKietzmann commented Nov 26, 2014

Uh oh!

haukepetersen commented Nov 26, 2014

Uh oh!

OlegHahm commented Nov 26, 2014

Uh oh!

BytesGalore commented Nov 26, 2014

Uh oh!

LudwigKnuepfer commented Nov 26, 2014

Uh oh!

LudwigKnuepfer commented Jan 14, 2017

Uh oh!

PeterKietzmann commented Jan 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants