Skip to content

cpu/avr8_common: Fix link with binutils > 2.35.2 [backport 2021.10]#16990

Merged
benpicco merged 1 commit intoRIOT-OS:2021.10-branchfrom
maribu:backport/2021.10/cpu/avr8_common/ldscripts
Oct 18, 2021
Merged

cpu/avr8_common: Fix link with binutils > 2.35.2 [backport 2021.10]#16990
benpicco merged 1 commit intoRIOT-OS:2021.10-branchfrom
maribu:backport/2021.10/cpu/avr8_common/ldscripts

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Oct 15, 2021

Backport of #16790

Contribution description

The xfa.ld script is incompatible with binutils > 2.35.2 and results in firmwares that wont boot. Sadly, I couldn't figure out an elegant way to fix the issue. Instead, I modified the linker script provided by binutils to also include XFA.

Testing procedure

  • tests/xfa should again still compile, flash, and boot
  • any other application should again compile, flash, and boot

Issues/PRs references

Fixes #16251

@maribu maribu requested a review from kYc0o as a code owner October 15, 2021 08:00
@maribu maribu added Area: build system Area: Build system Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Oct 15, 2021
@maribu maribu mentioned this pull request Oct 15, 2021
Merged
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2021
@benpicco benpicco added this to the Release 2021.10 milestone Oct 15, 2021
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2021
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 17, 2021
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Oct 18, 2021

This needs a rebase

@maribu
cpu/avr8_common: Fix link with binutils > 2.35.2
cdb128e 
The xfa.ld script is incompatible with binutils > 2.35.2 and results
in firmwares that wont boot. Sadly, I couldn't figure out an elegant
way to fix the issue. Instead, I modified the linker script provided
by binutils to also include XFA.

(cherry picked from commit 62d6a56)
@maribu maribu force-pushed the backport/2021.10/cpu/avr8_common/ldscripts branch from 738e61f to cdb128e Compare October 18, 2021 14:48
@benpicco benpicco merged commit 67a5147 into RIOT-OS:2021.10-branch Oct 18, 2021
@maribu maribu deleted the backport/2021.10/cpu/avr8_common/ldscripts branch October 18, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@kYc0o kYc0o Awaiting requested review from kYc0o kYc0o is a code owner

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2021.10

Development

Successfully merging this pull request may close these issues.

2 participants

@maribu @benpicco