cpu/{atxmega,atmega_common}: fix invalid use of PSTR()#16920
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Oct 1, 2021
Merged
cpu/{atxmega,atmega_common}: fix invalid use of PSTR()#16920benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
maribu
added
Type: bug
maribu
added
the
CI: ready for build
benpicco
approved these changes
Sep 30, 2021
3 tasks
Member
Author
|
Looks like quite a few applications are now out of RAM, since the error message is placed into |
core_panic() doesn't expect the message to be in program memory, but in data memory. Bad things will happen on AVR when the address is interpreted as being in data address space, but the allocation is done in program address space.
maribu
force-pushed
the
cpu/avr8_common/bugfix
branch
from
832369b to
35a1b60
Compare
Contributor
|
That makes me wonder, how much would be needed to have functions that print fixed strings from PROGMEM? |
Member
Author
|
The avrlibc has special printf format specifier for that, or using |
benpicco
added
CI: ready for build
Member
Author
|
Backport provided in #16933 |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
core_panic() doesn't expect the message to be in program memory, but
in data memory. Bad things will happen on AVR when the address is
interpreted as being in data address space, but the allocation is
done in program address space.
Testing procedure
The corresponding panics (and IRQ without provided ISR) should print something sensible again.
Issues/PRs references
None