Skip to content

nanocoap & gcoap: allow path to be non-\0-terminated.#16712

Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom
miri64:gcoap+nanocoap/enh/buffer-path
Aug 5, 2021
Merged

nanocoap & gcoap: allow path to be non-\0-terminated.#16712
benpicco merged 2 commits intoRIOT-OS:masterfrom
miri64:gcoap+nanocoap/enh/buffer-path

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 5, 2021

Contribution description

When working with modules such as uri_parser, where the path is not necessarily \0-terminated, this change greatly simplifies working with these modules.

Testing procedure

examples/gcoap should still be able to exchange messages, same for tests/nanocoap_cli.

Issues/PRs references

None.

This simplifies the usage of `nanocoap` with modules such as
`uri_parser` greatly.
@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. labels Aug 5, 2021
@github-actions github-actions bot added Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System labels Aug 5, 2021
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 5, 2021
This simplifies the usage of `gcoap` with modules such as `uri_parser`
greatly.
@miri64 miri64 force-pushed the gcoap+nanocoap/enh/buffer-path branch from c80b8b1 to 5d59065 Compare August 5, 2021 11:31
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, closes #15697

@benpicco benpicco merged commit 81df6d6 into RIOT-OS:master Aug 5, 2021
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 5, 2021

Oops, sorry, did not look if this work already exists.

@miri64 miri64 deleted the gcoap+nanocoap/enh/buffer-path branch August 5, 2021 15:35
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants