event_timeout: check clock before removing ztimer on clear #16667
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Jul 21, 2021
Merged
event_timeout: check clock before removing ztimer on clear #16667miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64 merged 2 commits intoRIOT-OS:masterfrom
Conversation
miri64
added
the
Type: bug
miri64
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
kaspar030,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Area: sys
miri64
added
CI: ready for build
fjmolinas
approved these changes
Jul 21, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
ACK, although I believe that it's normal that if an object is used uninitialized then any operation on such object could lead to errors.
Member
Author
Well, the alternative would be that for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently,
event_timeout_clear()crashes when used withztimerand when the timeout is uninitialized. This isn't the same behavior as withxtimer. As such, check the clock variable (which when set toNULLcauses the crash) before clearing the timer.Testing procedure
tests/eventshould pass. When the fix is reverted, it crashes.Issues/PRs references
None.