dhcpv6_client: make IA_PD an optional module#16658
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jul 21, 2021
Merged
Conversation
miri64
added
the
Type: cleanup
miri64
requested review from
PeterKietzmann,
cgundogan and
haukepetersen
as code owners
github-actions
bot
added
Area: build system
benpicco
added
the
CI: ready for build
miri64
force-pushed
the
dhcpv6_client/enh/optional-ia_pd
branch
from
233249e to
32dfb61
Compare
benpicco
reviewed
Jul 20, 2021
Member
Author
|
Addressed the change requests. |
miri64
force-pushed
the
dhcpv6_client/enh/optional-ia_pd
branch
from
3feed1e to
8f8f06b
Compare
Contributor
|
Please squash! |
Prefix delegation used to be the only supported feature of our DHCPv6 client, but by now it also supports MUD, DNS recursive name servers and IA_NA is on the horizon. So it makes sense to make IA_PD an optional module like all those other features are as well.
miri64
force-pushed
the
dhcpv6_client/enh/optional-ia_pd
branch
from
8f8f06b to
38d14b6
Compare
Member
Author
$ git rebase -i HEAD~3 --autosquash
:x
Successfully rebased and updated refs/heads/dhcpv6_client/enh/optional-ia_pd. |
benpicco
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Prefix delegation used to be the only supported feature of our DHCPv6 client, but by now it also supports MUD, DNS recursive name servers and IA_NA is on the horizon. So it makes sense to make IA_PD an optional module like all those other features are as well.
Testing procedure
Binary sizes of the
tests/gnrc_dhcpv6_*test applications as well as the border router withUSE_DHCPV6=1should stay the same with and without this fix (build withRIOT_CI_BUILD=1).When removing the line
RIOT/tests/gnrc_dhcpv6_client/Makefile
Line 11 in 233249e
the build size should decrease drastically. The test will fail (since it checks for working prefix delegation), but it should not crash during the run. Additionally, one may check if the proper DHCPv6 handshake of SOLICIT -> ADVERTISE -> REQUEST -> REPLY is completed, either by sniffing the traffic during the test or by enabling DEBUG here
RIOT/sys/net/application_layer/dhcpv6/client.c
Line 29 in 233249e
Issues/PRs references
None.