Skip to content

drivers/nrf802154: remove nrf802154_rf_netdev_legacy#16630

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/remove_nrf52840_legacy
Jul 9, 2021
Merged

drivers/nrf802154: remove nrf802154_rf_netdev_legacy#16630
maribu merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/remove_nrf52840_legacy

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Jul 8, 2021

Contribution description

Analog to #16628

This PR removes the legacy netdev implementation of nrf802154.

From now on, only the Radio HAL variant is available, but users can still use this radio as a netdev interface using netdev_ieee802154_submac. Therefore this shouldn't be consider as an API change. Although it's true that some NETOPTs are not (yet) exposed by netdev_ieee802154_submac, the legacy version doesn't implement retransmissions nor CSMA-CA, which makes it hard to use it in real scenarios.

Testing procedure

examples/gnrc_networking should still work with any nrf802154 based board (e.g nrf52840dk)

Issues/PRs references

#13943 #16628

@github-actions github-actions bot added Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Jul 8, 2021
@jia200x jia200x added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Jul 8, 2021
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 8, 2021
Copy link
Copy Markdown
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@maribu maribu merged commit 03670e6 into RIOT-OS:master Jul 9, 2021
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants