drivers/cc2538_rf: remove cc2538_rf_netdev_legacy#16628
Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom Jul 8, 2021
Merged
drivers/cc2538_rf: remove cc2538_rf_netdev_legacy#16628jia200x merged 1 commit intoRIOT-OS:masterfrom
jia200x merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: build system
benpicco
added
CI: ready for build
benpicco
approved these changes
Jul 8, 2021
maribu
approved these changes
Jul 8, 2021
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
High level ACK. (I didn't do full review, but trust @benpicco review instead. I agree on a conceptional level that we shouldn't maintain legacy drivers when new drivers are ready, unless we really have strong reasons to burden us with the duplicated effort. So if someone thinks this formally needs a second ACK, here it is.)
Member
Author
|
thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the legacy netdev implementation of CC2538.
From now on, only the Radio HAL variant is available, but users can still use this radio as a netdev interface using
netdev_ieee802154_submac. Therefore this shouldn't be consider as an API change. Although it's true that some NETOPTs are not (yet) exposed bynetdev_ieee802154_submac, the legacy version doesn't implement retransmissions nor CSMA-CA, which makes it hard to use it in real scenarios.Testing procedure
examples/gnrc_networkingshould still work with any cc2538 based board (e.gremote-revb)Issues/PRs references
#13943