Skip to content

gnrc_lorawan: fix gnrc_pktbuf_release_error (introduced by #16080)#16617

Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/gnrc_lorawan_fix_release
Jul 7, 2021
Merged

gnrc_lorawan: fix gnrc_pktbuf_release_error (introduced by #16080)#16617
jia200x merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/gnrc_lorawan_fix_release

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Jul 6, 2021

Contribution description

This PR fixes an issue introduced by #16080, in which the wrong pktsnip is released on TX errors.
I removed the head variable and asserted "payload" just to avoid this kind of mistakes in the future.

Testing procedure

It's quite hard to test LoRAWAN right now if we don't have working setups with TTN, but I have a running instance of Chirpstack. I will post results ASAP.

If the transmissions fails (e.g the node didn't join), there's an assertion on master:

2021-07-06 13:59:26,331 # txtsnd 3 02 test
2021-07-06 13:59:26,338 # sys/net/gnrc/pktbuf/gnrc_pktbuf.c:94 => 0x8000165
2021-07-06 13:59:26,340 # *** RIOT kernel panic:
2021-07-06 13:59:26,341 # FAILED ASSERTION.

With this PR:

2021-07-06 14:28:20,569 # reboot
2021-07-06 14:28:20,613 # NETOPT_RX_END_IRQ not implemented by driver
2021-07-06 14:28:20,621 # main(): This is RIOT! (Version: 2021.07-devel-489-g13274-pr/gnrc_lorawan_fix_release)
2021-07-06 14:28:20,626 # Initialization successful - starting the shell now
> txtsnd 3 01 test
2021-07-06 14:28:25,992 # txtsnd 3 01 test
> txtsnd 3 01 test
2021-07-06 14:28:26,840 # txtsnd 3 01 test
2021-07-06 14:28:27,021 # txtsnd 3 01 test
2021-07-06 14:28:27,169 # txtsnd 3 01 test
2021-07-06 14:28:27,318 # txtsnd 3 01 test
2021-07-06 14:28:27,460 # txtsnd 3 01 test
2021-07-06 14:28:27,603 # txtsnd 3 01 test
2021-07-06 14:28:27,756 # txtsnd 3 01 test
2021-07-06 14:28:29,070 # txtsnd 3 01 test
> txtsnd 3 01 test
2021-07-06 14:28:30,244 # txtsnd 3 01 test

Issues/PRs references

#16080

@jia200x jia200x added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Area: LoRa Area: LoRa radio support labels Jul 6, 2021
@jia200x jia200x requested review from MrKevinWeiss and fjmolinas July 6, 2021 12:40
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System and removed Area: LoRa Area: LoRa radio support labels Jul 6, 2021
fjmolinas
fjmolinas approved these changes Jul 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, as @jia200x mentions its hard to test with no gateway, I don't have access to one ATM, so trusting his testing, and the change is sensible.

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 6, 2021
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jul 7, 2021

thanks for the review!

@jia200x jia200x merged commit ed16920 into RIOT-OS:master Jul 7, 2021
This was referenced Jul 7, 2021
Closed
Merged
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

No one assigned

Labels

Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2021.10

Development

Successfully merging this pull request may close these issues.

3 participants

@jia200x @fjmolinas @benpicco