Skip to content

ztimer: pull ztimer_periph_rtt for ZTIMER_MSEC if available#16553

Merged
jia200x merged 2 commits intoRIOT-OS:masterfrom
fjmolinas:pr_ztimer_enable_rtt
Jun 16, 2021
Merged

ztimer: pull ztimer_periph_rtt for ZTIMER_MSEC if available#16553
jia200x merged 2 commits intoRIOT-OS:masterfrom
fjmolinas:pr_ztimer_enable_rtt

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Jun 15, 2021

Contribution description

With #16546 ztimer_periph_rtt can always be included since all rtt are capable of supplying a msec timer, so this PR includes it by default.

I'm not sure how the Kconfig dependency should be adapted, I gave it a go but maybe @leandrolanzieri could take a second look.

Testing procedure

Included modules should be the same for the affected pkgs, rtt is included when possible otherwise ztimer_msec fallbacks to periph_timer,

Issues/PRs references

Takeover of #16334

@github-actions github-actions bot added Area: BLE Area: Bluetooth Low Energy support Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: timers Area: timer subsystems labels Jun 15, 2021
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 15, 2021
@fjmolinas fjmolinas force-pushed the pr_ztimer_enable_rtt branch from 7f0f6ff to 00bd117 Compare June 15, 2021 13:29
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jun 15, 2021

Applied offline suggestion from @leandrolanzieri, each CLOCK can configure a different backend.

image

This was referenced Jun 15, 2021
Merged
Closed
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jun 15, 2021

LGTM, can't say much about the Kconfig part, though. @jia200x @leandrolanzieri mind to take a look? (Murdock shows some errors).

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 15, 2021

One difference that I see, is that with the change introduced in Kconfig, where each clock allows to select a backend, now the RTC backend is included, which did not happen before. This causes in native to also bring xtimer, as RTC in native is done with xtimer :/ Perhaps add it as an exception?

@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jun 15, 2021

LGTM, can't say much about the Kconfig part, though. @jia200x @leandrolanzieri mind to take a look? (Murdock shows some errors).

Indeed for some reason xtiemr got pulled in... looking into it

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jun 15, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jun 16, 2021

Murdock is happy this time, @leandrolanzieri do you think everything is OK?

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 16, 2021

Murdock is happy this time, @leandrolanzieri do you think everything is OK?

The Kconfig looks good to me!

@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jun 16, 2021

@kaspar030 @leandrolanzieri may I squash?

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 16, 2021

Go ahead!

kaspar030
kaspar030 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@fjmolinas fjmolinas force-pushed the pr_ztimer_enable_rtt branch from 5a079da to 3e4e664 Compare June 16, 2021 09:18
@jia200x jia200x merged commit 9954ac8 into RIOT-OS:master Jun 16, 2021
@jia200x jia200x mentioned this pull request Jun 16, 2021
Merged
@fjmolinas fjmolinas mentioned this pull request Jun 16, 2021
Merged
@aabadie aabadie mentioned this pull request Jun 17, 2021
Merged
@fjmolinas fjmolinas mentioned this pull request Jun 18, 2021
Merged
@MrKevinWeiss MrKevinWeiss added Process: release backport Integration Process: The PR is a release backport of a change previously provided to master and removed Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Jul 15, 2021
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jul 15, 2021
@fjmolinas fjmolinas deleted the pr_ztimer_enable_rtt branch July 30, 2021 11:28
@fjmolinas fjmolinas mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: BLE Area: Bluetooth Low Energy support Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2021.07

Development

Successfully merging this pull request may close these issues.

5 participants

@fjmolinas @kaspar030 @leandrolanzieri @jia200x @MrKevinWeiss