gnrc_tcp: rewrite passive open by brummer-simon · Pull Request #16459 · RIOT-OS/RIOT

brummer-simon · 2021-05-08T07:20:59Z

Contribution description

This PR rewrites the passive connection establishment mechanism of GNRC_TCP.
The new version aligns the GNRC_TCP interface with the SOCK_TCP interface with the goal to make a upcoming SOCK integration straight forward and trivial.

Since this is a large change, I've split the PR into three commits (api, implementation and tests) to help reviewing this.
The new tests are written in different style than existing tests, please ignore the difference in style for now, I plan to align the existing test structure in a dedicated PR on after merging this.

Testing procedure

This PR is covered by the GNRC_TCP test suite.
To test this PR follow the instructions under tests/gnrc_tcp/Readme.md

Issues/PRs references

Fixes #10664 - TCP Sockets can not be used / built

MrKevinWeiss · 2021-06-24T11:55:01Z

Should we move this to next release as it is soft feature freeze and this contains an API change?

brummer-simon · 2021-06-24T13:11:09Z

This PR and the followup PR contain large API changes. Although the changes are tested in depth, it might be much effort to review all of this. I personally don't care if this is part of this release or the next. From my side, do whatever relaxes your release management. ;)

benpicco

This looks good at a cursory glance

sys/net/gnrc/transport_layer/tcp/gnrc_tcp.c

sys/net/gnrc/transport_layer/tcp/gnrc_tcp_fsm.c

benpicco

Looks good to me, Murdock should ensure that the tests are still passing on native.

miri64 · 2021-07-04T14:48:09Z

Looks good to me, Murdock should ensure that the tests are still passing on native.

Given that the tests require root it probably doesn't ;-).

benpicco · 2021-07-04T19:45:49Z

True - but Murdock found that compile/fuzzing/gnrc_tcp does not compile anymore now.

brummer-simon · 2021-07-05T08:55:44Z

True - but Murdock found that compile/fuzzing/gnrc_tcp does not compile anymore now.

Should be fixed by now

miri64 · 2021-07-05T09:43:35Z

Nevertheless the test-as-root target should be run by a maintainer on a handful of platforms locally before merging ;-). If I find the time I will do :-).

miri64

Ok, now I looked at the code and found a problem 😅 .

miri64

Not sure, why my review comment did not get posted though.

fuzzing/gnrc_tcp/main.c

brummer-simon · 2021-07-05T09:55:20Z

Nevertheless the test-as-root target should be run by a maintainer on a handful of platforms locally before merging ;-). If I find the time I will do :-).

Thanks

miri64 · 2021-07-06T13:12:50Z

Mh test works on native, but not on samr21-xpro, which isn't the case on master :-/. I'll post the relevant output with echo activated. Maybe you have an idea.

miri64 · 2021-07-06T13:13:57Z

Here it is

01-conn_lifecycle_as_client.py: success

02-conn_lifecycle_as_server.py: success

03-send_data.py: success

04-receive_data.py: success



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_open_passive [::]:36511
> gnrc_tcp_open_passive: argc=2, argv[0] = gnrc_tcp_open_passive, argv[1] = [::]:36511
- test_short_payload gnrc_tcp_open_passive: returns 0
gnrc_tcp_recv 1000000 1
> gnrc_tcp_recv: argc=3, argv[0] = gnrc_tcp_recv, argv[1] = 1000000, argv[2] = 1
gnrc_tcp_recv: received 1
pktbuf
> packet buffer: first byte: 0x20002690, last byte: 0x20003e90 (size: 6144)
  position of last byte used: 392
~ unused: 0x20002690 (next: (nil), size: 6144) ~

gnrc_tcp_close



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_open_passive [::]:44364
> gnrc_tcp_open_passive: argc=2, argv[0] = gnrc_tcp_open_passive, argv[1] = [::]:44364
- test_short_header gnrc_tcp_open_passive: returns 0
pktbuf
> packet buffer: first byte: 0x20002690, last byte: 0x20003e90 (size: 6144)
  position of last byte used: 392
~ unused: 0x20002690 (next: (nil), size: 6144) ~

gnrc_tcp_close



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_open_passive [::]:38905
> gnrc_tcp_open_passive: argc=2, argv[0] = gnrc_tcp_open_passive, argv[1] = [::]:38905
- test_send_ack_instead_of_syn gnrc_tcp_close

Traceback (most recent call last):
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py", line 154, in <module>
    res = run(test, timeout=10, echo=True)
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/dist/pythonlibs/testrunner/__init__.py", line 30, in run
    testfunc(child)
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py", line 45, in runner
    func(child, tap, host_ll, dst_if, dst_l2, dst_ll, port)
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py", line 124, in test_send_ack_instead_of_syn
    sock.connect(addr_info[0][-1])
socket.timeout: timed out
make: *** [/home/mlenders/Repositories/RIOT-OS/RIOT/makefiles/tests/tests.inc.mk:35: test-as-root] Error 1

brummer-simon · 2021-07-06T13:27:11Z

Here it is

01-conn_lifecycle_as_client.py: success

02-conn_lifecycle_as_server.py: success

03-send_data.py: success

04-receive_data.py: success



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_open_passive [::]:36511
> gnrc_tcp_open_passive: argc=2, argv[0] = gnrc_tcp_open_passive, argv[1] = [::]:36511
- test_short_payload gnrc_tcp_open_passive: returns 0
gnrc_tcp_recv 1000000 1
> gnrc_tcp_recv: argc=3, argv[0] = gnrc_tcp_recv, argv[1] = 1000000, argv[2] = 1
gnrc_tcp_recv: received 1
pktbuf
> packet buffer: first byte: 0x20002690, last byte: 0x20003e90 (size: 6144)
  position of last byte used: 392
~ unused: 0x20002690 (next: (nil), size: 6144) ~

gnrc_tcp_close



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_open_passive [::]:44364
> gnrc_tcp_open_passive: argc=2, argv[0] = gnrc_tcp_open_passive, argv[1] = [::]:44364
- test_short_header gnrc_tcp_open_passive: returns 0
pktbuf
> packet buffer: first byte: 0x20002690, last byte: 0x20003e90 (size: 6144)
  position of last byte used: 392
~ unused: 0x20002690 (next: (nil), size: 6144) ~

gnrc_tcp_close



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_open_passive [::]:38905
> gnrc_tcp_open_passive: argc=2, argv[0] = gnrc_tcp_open_passive, argv[1] = [::]:38905
- test_send_ack_instead_of_syn gnrc_tcp_close

Traceback (most recent call last):
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py", line 154, in <module>
    res = run(test, timeout=10, echo=True)
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/dist/pythonlibs/testrunner/__init__.py", line 30, in run
    testfunc(child)
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py", line 45, in runner
    func(child, tap, host_ll, dst_if, dst_l2, dst_ll, port)
  File "/home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py", line 124, in test_send_ack_instead_of_syn
    sock.connect(addr_info[0][-1])
socket.timeout: timed out
make: *** [/home/mlenders/Repositories/RIOT-OS/RIOT/makefiles/tests/tests.inc.mk:35: test-as-root] Error 1

The log seems strange to me since it sends gnrc_tcp_open_passive to the target, a function that should not exist anymore. Could you perform a clean build and test again?

miri64 · 2021-07-06T13:28:35Z

I don't see how a clean build has any effect on the test script ;-).

miri64 · 2021-07-06T13:31:51Z

But did just that and same result.

miri64 · 2021-07-06T13:33:31Z

Ah wait, the output indeed differs

Details

01-conn_lifecycle_as_client.py: success


- Test "test_lifecycle_as_server": SUCCESS
02-conn_lifecycle_as_server.py: success

03-send_data.py: success

04-receive_data.py: success



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_listen [::]:20132
gnrc_tcp_tcb_init: returns 0
> gnrc_tcp_listen: argc=2, argv[0] = gnrc_tcp_listen, argv[1] = [::]:20132
gnrc_tcp_accept 2000
- test_short_payload gnrc_tcp_listen: returns 0
> gnrc_tcp_accept: argc=2, argv[0] = gnrc_tcp_accept, argv[1] = 2000
gnrc_tcp_accept: returns 0
gnrc_tcp_recv 1000000 1
> gnrc_tcp_recv: argc=3, argv[0] = gnrc_tcp_recv, argv[1] = 1000000, argv[2] = 1
gnrc_tcp_recv: received 1
pktbuf
> packet buffer: first byte: 0x200026b4, last byte: 0x20003eb4 (size: 6144)
  position of last byte used: 392
~ unused: 0x200026b4 (next: (nil), size: 6144) ~

gnrc_tcp_close
gnrc_tcp_stop_listen



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_listen [::]:41242
gnrc_tcp_tcb_init: returns 0
> gnrc_tcp_listen: argc=2, argv[0] = gnrc_tcp_listen, argv[1] = [::]:41242
gnrc_tcp_accept 2000
- test_short_header gnrc_tcp_listen: returns 0
> gnrc_tcp_accept: argc=2, argv[0] = gnrc_tcp_accept, argv[1] = 2000
gnrc_tcp_accept: returns 0
pktbuf
> packet buffer: first byte: 0x200026b4, last byte: 0x20003eb4 (size: 6144)
  position of last byte used: 392
~ unused: 0x200026b4 (next: (nil), size: 6144) ~

gnrc_tcp_close
gnrc_tcp_stop_listen



make[2]: Nothing to be done for 'all'.
sudo /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/ethos/ethos tap0 /dev/ttyACM0 115200 
----> ethos: sending hello.
----> ethos: activating serial pass through.
----> ethos: hello reply received
ifconfig
> > Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
ifconfig
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> ifconfig
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init
Iface  4  HWaddr: 66:DA:1D:63:7D:CF 
          L2-PDU:1500  MTU:1500  HL:64  Source address length: 6
          Link type: wired
          inet6 addr: fe80::64da:1dff:fe63:7dcf  scope: link  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ff63:7dcf
          
> gnrc_tcp_tcb_init: argc=1, argv[0] = gnrc_tcp_tcb_init
gnrc_tcp_listen [::]:51203
gnrc_tcp_tcb_init: returns 0
> gnrc_tcp_listen: argc=2, argv[0] = gnrc_tcp_listen, argv[1] = [::]:51203
gnrc_tcp_accept 2000
- test_send_ack_instead_of_syn gnrc_tcp_listen: returns 0
> gnrc_tcp_accept: argc=2, argv[0] = gnrc_tcp_accept, argv[1] = 2000
gnrc_tcp_accept: returns -ETIMEDOUT
> gnrc_tcp_close
gnrc_tcp_stop_listen
Timeout in expect script at "child.expect_exact('gnrc_tcp_accept: returns 0')" (tests/gnrc_tcp/tests-as-root/05-garbage-pkts.py:128)

brummer-simon · 2021-07-06T14:28:46Z

Seems like a timeout thats large enough on native. I'll see if I can find a board here and try to determine a suitable value

brummer-simon · 2021-07-06T15:29:15Z

@miri64 - I tested the PR on the nucleo-f401re and it worked. I added a commit increasing the accept timeout in the failing test script from 2000ms to 4000ms, I hope this is long enough for all boards with less processing power.

The failing test is the one where 1000 malformed packets are send and discarded, afterwards a valid packet is sent and used to accept the connection. In that test processing power might be the limiting factor. Could you test again?

miri64 · 2021-07-07T17:01:02Z

Nope. But 10000 works. How about, just to be on the save side to set it to 15000? Also if that is done, please squash the commits reflecting the review history.

brummer-simon · 2021-07-07T17:46:48Z

Nope. But 10000 works. How about, just to be on the save side to set it to 15000? Also if that is done, please squash the commits reflecting the review history.

Done

miri64 · 2021-07-07T20:57:04Z

0d5db28 still needs to be squashed in the original commits.

brummer-simon · 2021-07-08T04:17:08Z

0d5db28 still needs to be squashed in the original commits.

Forgot this one. I squashed it.

miri64

ACK

miri64 · 2021-07-08T06:54:58Z

Not sure why murdock is marked as failed or still doing label checks...

brummer-simon · 2021-07-08T06:59:23Z

@miri64: Should I squash it in a single commit? I splitted the PR only to help with the review.

EDIT: Since all is reviewed and green, I just squash the entire thing and merge it.

brummer-simon · 2021-07-08T08:57:03Z

@miri64 , @benpicco, since everything is green, could you press the merge button? For an unknown reason I am not able to do that anymore :(

miri64 · 2021-07-08T14:09:08Z

@miri64 , @benpicco, since everything is green, could you press the merge button? For an unknown reason I am not able to do that anymore :(

Where you ever? You need write permissions to hit the green button (which only maintainers have).

brummer-simon · 2021-07-08T14:11:34Z

Maybe my mind is playing a trick on me but I could swere that there was I time were I was able to press the merge button for my own PR after a successfull review. But I had never maintainer status.

brummer-simon requested review from PeterKietzmann, cgundogan, haukepetersen and miri64 as code owners May 8, 2021 07:21

benpicco added Area: network Area: Networking Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels May 8, 2021

brummer-simon mentioned this pull request May 8, 2021

gnrc_tcp: refactor tests #16461

Merged

jeandudey added this to the Release 2021.07 milestone May 12, 2021

miri64 added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label May 17, 2021

This was referenced May 22, 2021

gnrc_tcp: align with sock tcp #16493

Merged

gnrc_sock_tcp: add gnrc sock tcp #16494

Merged

MrKevinWeiss modified the milestones: Release 2021.07, Release 2021.10 Jun 24, 2021

MrKevinWeiss added the Process: blocked by feature freeze Integration Process: The impact of this PR is too high for merging it during soft feature freeze. label Jun 24, 2021

benpicco reviewed Jul 1, 2021

View reviewed changes

sys/net/gnrc/transport_layer/tcp/gnrc_tcp.c Show resolved Hide resolved

sys/net/gnrc/transport_layer/tcp/gnrc_tcp.c Outdated Show resolved Hide resolved

sys/net/gnrc/transport_layer/tcp/gnrc_tcp_fsm.c Outdated Show resolved Hide resolved

github-actions bot added Area: doc Area: Documentation Area: sys Area: System Area: tests Area: tests and testing framework labels Jul 2, 2021

benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Process: blocked by feature freeze Integration Process: The impact of this PR is too high for merging it during soft feature freeze. labels Jul 4, 2021

benpicco approved these changes Jul 4, 2021

View reviewed changes

miri64 requested changes Jul 5, 2021

View reviewed changes

miri64 reviewed Jul 5, 2021

View reviewed changes

fuzzing/gnrc_tcp/main.c Outdated Show resolved Hide resolved

miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jul 8, 2021

miri64 approved these changes Jul 8, 2021

View reviewed changes

miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 8, 2021

gnrc_tcp: add listen/accept

88a0273

fjmolinas merged commit 79ee4fd into RIOT-OS:master Jul 8, 2021

brummer-simon deleted the gnrc_tcp-rewrite_passive_open branch July 8, 2021 12:08

Conversation

brummer-simon commented May 8, 2021 • edited by miri64 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

MrKevinWeiss commented Jun 24, 2021

Uh oh!

brummer-simon commented Jun 24, 2021

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 commented Jul 4, 2021

Uh oh!

benpicco commented Jul 4, 2021

Uh oh!

brummer-simon commented Jul 5, 2021

Uh oh!

miri64 commented Jul 5, 2021

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brummer-simon commented Jul 5, 2021

Uh oh!

miri64 commented Jul 6, 2021

Uh oh!

miri64 commented Jul 6, 2021

Uh oh!

brummer-simon commented Jul 6, 2021

Uh oh!

miri64 commented Jul 6, 2021

Uh oh!

miri64 commented Jul 6, 2021

Uh oh!

miri64 commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brummer-simon commented Jul 6, 2021

Uh oh!

brummer-simon commented Jul 6, 2021

Uh oh!

miri64 commented Jul 7, 2021

Uh oh!

brummer-simon commented Jul 7, 2021

Uh oh!

miri64 commented Jul 7, 2021

Uh oh!

brummer-simon commented Jul 8, 2021

Uh oh!

miri64 left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 commented Jul 8, 2021

Uh oh!

brummer-simon commented Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brummer-simon commented Jul 8, 2021

Uh oh!

miri64 commented Jul 8, 2021

Uh oh!

brummer-simon commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

brummer-simon commented May 8, 2021 •

edited by miri64

Loading

miri64 commented Jul 6, 2021 •

edited

Loading

brummer-simon commented Jul 8, 2021 •

edited

Loading