Skip to content

tests/periph_spi: compact help messages a bit to shave off some bytes#16094

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:reduce_tests_periph_spi_codesize
Feb 25, 2021
Merged

tests/periph_spi: compact help messages a bit to shave off some bytes#16094
miri64 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:reduce_tests_periph_spi_codesize

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Feb 25, 2021 •
edited
Loading

Contribution description

#16061 exposed that on 16kb flash ARM boards (e.g., samd10-xmini), tests/periph_spi_dma is borderline not fitting, with maybe 50b left.

This PR just compacts the bootup message slightly:

PR:

   text    data     bss     dec     hex filename
  16244      44    3860   20148    4eb4 /data/riotbuild/riotbase/tests/periph_spi_dma/bin/samd10-xmini/tests_periph_spi_dma.elf

master:

   text    data     bss     dec     hex filename
  16284      44    3860   20188    4edc /data/riotbuild/riotbase/tests/periph_spi_dma/bin/samd10-xmini/tests_periph_spi_dma.elf

Testing procedure

CI should be fine.

Issues/PRs references

@kaspar030 kaspar030 added Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 25, 2021
@kaspar030 kaspar030 mentioned this pull request Feb 25, 2021
Closed
miri64
miri64 approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Shaving of some ROM by compressing output is always a good deal :-) (unless information to the user is lost, which isn't the case here).

@miri64 miri64 merged commit 6b827f4 into RIOT-OS:master Feb 25, 2021
@kaspar030 kaspar030 deleted the reduce_tests_periph_spi_codesize branch February 25, 2021 13:48
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Feb 25, 2021

Thanks! ;)

@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
@kaspar030 kaspar030 added the Release notes: ignored Set on PRs that have been considered for inclusion in the current release's notes but were minor. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees

No one assigned

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Release notes: ignored Set on PRs that have been considered for inclusion in the current release's notes but were minor. Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2021.04

Development

Successfully merging this pull request may close these issues.

2 participants

@kaspar030 @miri64