core/thread: move thread configuration into seperate header#16024
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Mar 2, 2021
Merged
core/thread: move thread configuration into seperate header#16024kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
kaspar030
added
Area: core
Closed
kaspar030
removed
the
CI: ready for build
maribu
reviewed
Feb 16, 2021
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
The CI has some feedback.
A follow up step would IMO be to move out the arch specific configs to cpu/<SOME_ARCH>_common/include/thread_config_arch.h, so that cpu_conf.h is no longer needed.
Member
|
@kaspar030: Ping? I volunteer to do the follow up. The vendor files get included has again bitten me in the ass, I finally want to get rid of this issue. |
kaspar030
added
the
CI: ready for build
kaspar030
force-pushed
the
refactor_thread_config
branch
from
1aa6f8e to
e8e8405
Compare
Contributor
Author
|
squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR moves some thread configuration defines from thread.h into thread_config.h.
As is, this only moves code around, but it is the first step to untangle the thread.h API from cpu specific stuff (see e.g., here).
It is also a necessary step for providing alternative scheduler / core implementations.
Testing procedure
This only moves code around, so a CI success should be fine.
Issues/PRs references
Suggested in #15595.