Skip to content

sys/arduino: Bug and style fixes in SPI#15910

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
maribu:sys-arduino-spi-fix
Feb 2, 2021
Merged

sys/arduino: Bug and style fixes in SPI#15910
benpicco merged 1 commit intoRIOT-OS:masterfrom
maribu:sys-arduino-spi-fix

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Feb 2, 2021

Contribution description

  • set is_transaction before releasing the SPI bus (and the mutex) to avoid data races
  • adapt switch indent to coding convention

Testing procedure

This is trivial enough that IMO code review and CI should be sufficient.

Issues/PRs references

None

@maribu
sys/arduino: Bug and style fixes in SPI
45ed8bc 
- set is_transaction before releasing the SPI bus (and the mutex) to avoid
  data races
- adapt switch indent to coding convention
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: arduino API Area: Arduino wrapper API CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 2, 2021
@maribu maribu mentioned this pull request Feb 2, 2021
Merged
2 tasks
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Feb 2, 2021

Wow, that was a fast review :-)

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 2, 2021
@maribu maribu added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Feb 2, 2021
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Feb 2, 2021 •
edited
Loading

Skipping compile test, as the only failure is unrelated and caused by a CI hiccup.

Update: Restarting with CI tests re-enabled. Issue in the CI is fixed.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Feb 2, 2021
@benpicco benpicco merged commit 2313cef into RIOT-OS:master Feb 2, 2021
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
@maribu maribu deleted the sys-arduino-spi-fix branch January 23, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: arduino API Area: Arduino wrapper API CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2021.04

Development

Successfully merging this pull request may close these issues.

3 participants

@maribu @benpicco @kaspar030