sys/event: add event_wait_timeout_ztimer()#15789
Merged
fjmolinas merged 2 commits intoRIOT-OS:masterfrom Mar 31, 2021
Merged
Conversation
haukepetersen
added
Type: enhancement
haukepetersen
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
kaspar030,
leandrolanzieri and
smlng
as code owners
fjmolinas
reviewed
Feb 28, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Looks good, only a comment on how the test is integrated, see below.
Contributor
|
|
22 tasks
Contributor
|
ping @haukepetersen ! |
Contributor
|
ping @haukepetersen! |
haukepetersen
force-pushed
the
add_event_timeoutztimer
branch
from
8801400 to
6e09d2b
Compare
Contributor
Author
|
Sorry for the delay, had my head stuck somewhere else :-) Did address the open comments:
|
fjmolinas
added
the
CI: run tests
Contributor
|
Please squash @haukepetersen! |
Contributor
|
Ran the test on many BOARD's all passing: https://ci.inria.fr/ci-riot-tribe/job/build-pipeline.jk/259/artifact/ |
haukepetersen
force-pushed
the
add_event_timeoutztimer
branch
from
6e09d2b to
98de4b9
Compare
Contributor
Author
|
squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If one wants to use the timeout functionality with the
eventmodule, it is so far tied toxtimer. This PR also adds support to useztimerfor the same purpose, by introducing a new function calledevent_wait_timeout_ztimer(). This function allows to specify the used ztimer clock, and hence it can be used for any fitting time scale and no 64-bit version of that function is needed.I'd like to have this function merged to proceed on my path to remove any
xtimerandperiph_timerdependencies from NimBLE...Testing procedure
Run the
tests/event_wait_timeouttest on any platform of your choosing. It should still succeed.Issues/PRs references
none