ztimer: add ztimer_is_set() to user API#15780
Merged
kaspar030 merged 2 commits intoRIOT-OS:masterfrom Jan 20, 2021
Merged
Conversation
haukepetersen
added
Type: new feature
haukepetersen
requested review from
MichelRottleuthner,
aabadie,
bergzand,
fjmolinas,
leandrolanzieri and
smlng
as code owners
kaspar030
requested changes
Jan 15, 2021
Contributor
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
LGTM.
Please fix the uncrustify suggestion, ztimer is no-discission uncrustify (like core). You can squash it in directly.
Contributor
I didn't expose it because it feels a bit dangerous to say "false" if the wrong clock is parsed. On the other hand, I didn't want to add an extra "clock" field to ztimer_t just to be able to remove the clock parameter from is_set()... |
haukepetersen
force-pushed
the
opt_ztimer_isset
branch
from
33cd4bf to
d54e08f
Compare
Contributor
Author
|
fixed (and squashed) uncrustify issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
To improve the low power support I am currently porting NimBLE to use
ztimeras RIOT timer backend. Mapping theztimerAPI works mostly flawless, the only thing missing is ais_set()function. The current implementation uses an ugly hack by using xtimer internal struct members to do this check -> so for the improved port I'd like to have this less error prone :-)This PR simply exposes
ztimers internal_is_set()function by wrapping it into a critical section inside a newly addedztimer_is_set()user API function. Should be pretty straight forward.Testing procedure
I added a call to the new
ztimer_is_set()function intests/ztimer_periodic. So simply runtests/ztimer_periodicon any platform -> it should succeed as expected.Issues/PRs references
none