Skip to content

pkg/openthread: deprecate ot_command related functions#15664

Merged
MrKevinWeiss merged 4 commits intoRIOT-OS:masterfrom
jia200x:pr/openthread/deprecate_jobs
Jun 14, 2021
Merged

pkg/openthread: deprecate ot_command related functions#15664
MrKevinWeiss merged 4 commits intoRIOT-OS:masterfrom
jia200x:pr/openthread/deprecate_jobs

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Dec 17, 2020

Contribution description

Since #15038 saw the light, the current "ot_command" wrapper is only limiting OpenThread usage. The Event Queue makes it possible now to call OpenThread API functions directly when posting an event to the OpenThread queue.

This PR removes the ot_command calls from examples/openthread, improve Doxygen documentation and deprecate the "ot_command" related functions

Testing procedure

Test if examples/openthread still works ok. Note that it's possible to run OpenThread with any board that supports the Radio HAL if using netdev_ieee802154_submac.

Issues/PRs references

None so far

@benpicco benpicco added Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 17, 2020
aabadie
aabadie reviewed Dec 17, 2020
View reviewed changes
examples/openthread/main.c Outdated
uint16_t panid = 0;
uint8_t res = ot_call_command("panid", NULL, (void*)&panid);
printf("Current panid: 0x%x (res:%x)\n", panid, res);
puts("This a test for OpenThread");
Copy link
Copy Markdown
Contributor

@aabadie aabadie Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openthread is in examples/ so not really a test. I know it was there already but maybe we can take the opportunity of this PR to adapt.

Copy link
Copy Markdown
Member Author

@jia200x jia200x Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do it

Copy link
Copy Markdown
Member Author

@jia200x jia200x Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@jia200x jia200x force-pushed the pr/openthread/deprecate_jobs branch from 7a40453 to b73af6b Compare December 17, 2020 13:25
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jan 4, 2021

ping @aabadie

@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jan 14, 2021

let's postpone this one

@jia200x jia200x added this to the Release 2021.04 milestone Jan 14, 2021
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jun 9, 2021

ping

@github-actions github-actions bot added Area: examples Area: Example Applications Area: network Area: Networking labels Jun 14, 2021
benpicco
benpicco approved these changes Jun 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash!

@jia200x jia200x force-pushed the pr/openthread/deprecate_jobs branch from 4cd8fce to ef0b740 Compare June 14, 2021 13:35
@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Jun 14, 2021

Tested and it looks good:

Welcome to pyterm!
Type '/exit' to exit.
version
2021-06-14 15:57:15,777 # version
2021-06-14 15:57:15,783 # OPENTHREAD/thread-reference-20180926; NONE; Jun 14 2021 15:54:31
2021-06-14 15:57:15,784 # Done
> panid
2021-06-14 15:57:17,977 #  panid
2021-06-14 15:57:17,978 # beef
2021-06-14 15:57:17,978 # Done
>

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Jun 14, 2021

please rebase to maybe fix the pr_check error...

@jia200x jia200x force-pushed the pr/openthread/deprecate_jobs branch from ef0b740 to 0037210 Compare June 14, 2021 14:00
@MrKevinWeiss MrKevinWeiss merged commit adf228a into RIOT-OS:master Jun 14, 2021
@jia200x
Copy link
Copy Markdown
Member Author

jia200x commented Jun 14, 2021

thanks for the review!

@jia200x jia200x mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie left review comments

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees

No one assigned

Labels

Area: examples Area: Example Applications Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2021.07

Development

Successfully merging this pull request may close these issues.

5 participants

@jia200x @MrKevinWeiss @benpicco @aabadie @kaspar030