sys/ztimer: increase xtimer_compat coverage#15605
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Dec 13, 2020
Merged
Conversation
- add some xtimer specific defines some tests rely on
- provide the following missing functions:
- xtimer_ticks()
- xtimer_set_timeout_flag()
- xtimer_set_timeout_flag64()
- xtimer_spin()
maribu
added
Area: timers
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Dec 13, 2020
benpicco
reviewed
Dec 14, 2020
Comment on lines
+44
to
+45
| #define XTIMER_WIDTH (32) | ||
| #define XTIMER_MASK (0) |
Contributor
There was a problem hiding this comment.
Won't this conflict with the definition in board.h?
(sorry, noticed this too late)
kaspar030
reviewed
Dec 14, 2020
|
|
||
| static inline void xtimer_set_timeout_flag64(xtimer_t *t, uint64_t timeout) | ||
| { | ||
| xtimer_set_timeout_flag(t, timeout); |
Contributor
There was a problem hiding this comment.
This cuts off the high bits, silently, without comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
xtimer_ticks()xtimer_set_timeout_flag()xtimer_set_timeout_flag64()xtimer_spin()Testing procedure
USEMODULE=ztimer_xtimer_compat make flash text -C tests/thread_flagsUSEMODULE=ztimer_xtimer_compat make flash text -C tests/xtimer_now_irqShould now compile and pass, but fail to compile with
master.Issues/PRs references
None