stm32/flashpage: use void pointer for flash address#15410
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Nov 9, 2020
Merged
stm32/flashpage: use void pointer for flash address#15410aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie merged 1 commit intoRIOT-OS:masterfrom
Conversation
bergzand
added
Type: cleanup
7 tasks
benpicco
approved these changes
Nov 9, 2020
Contributor
|
Tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The stm32 flashpage implementation has a number of ifdefs to assign different pointer types to store the flashpage address. This address is only used as void pointers in the called functions. This PR removes the ifdefs with the different pointer sizes, replacing it with a single line using a void pointer.
Testing procedure
Compilation should be enough. Testing can be done using
tests/periph_flashpageon the various stm32 devices.Issues/PRs references
None