boards/nucleo-f746zg: Add dma, eth, pwm and spi feature#14731
boards/nucleo-f746zg: Add dma, eth, pwm and spi feature#14731aabadie merged 1 commit intoRIOT-OS:masterfrom
Conversation
|
Nice! |
1a0afc1 to
6f0168b
Compare
|
I updated my fork to add and update Kconfig which also fixed spi_dma bugs ! Now tests/periph_spi_dma bench is ok at all the clocks speed for both devices. |
|
It was a shame to be limited to a clock speed of 6.75MHz on a device that can go up to 50MHz and also to have twice the same speed of 421KHz for APB2. I have selected identical speeds for APB1 for better consistency in case someone wants to configure SPI2 or SPI3. |
aabadie
left a comment
There was a problem hiding this comment.
I have a comment regarding the spi configuration that I think could be simplified by reusing common code.
I haven't looked at the other configurations yet.
|
@hugueslarrive I can test this in the next few days. In the meantime could you please remove the obsolete commits here: 9dc703c, 12e3158 and 95d08ac. Could you also squash the remaining commits into a single commit with as message "boards/nucleo-f746zg: Add dma, eth, pwm and spi features" Thanks! |
9367fee to
8a9e717
Compare
8a9e717 to
fa19509
Compare
fa19509 to
0b648f4
Compare
|
tests/gnrc_udp: flood ping from linux host: Bug described in #13490 is still present. |
|
tests/periph_spi: |
|
tests/periph_spi_dma: |
|
tests/periph_pwm: |
aabadie
left a comment
There was a problem hiding this comment.
Compared with datasheet and reference manual and all values are correct AFAICS.
ACK

Contribution description
spi_dma and pwm could be backported to the 767zi but I haven't one to make tests.
Testing procedure
Issues/PRs references