Skip to content

tapsetup: fix for FreeBSD#14457

Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom
miri64:tapsetup/fix/freebsd
Jul 8, 2020
Merged

tapsetup: fix for FreeBSD#14457
bergzand merged 1 commit intoRIOT-OS:masterfrom
miri64:tapsetup/fix/freebsd

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jul 8, 2020 •
edited
Loading

Contribution description

While testing on FreeBSD (see #14458) I noticed some errors in our tapsetup script for FreeBSD.

Testing procedure

Read the script or use the VM I provided in #14458.

Issues/PRs references

Required for easier testing of #14458

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 8, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 8, 2020
@miri64 miri64 requested a review from benpicco July 8, 2020 07:05
@miri64 miri64 mentioned this pull request Jul 8, 2020
Merged
@miri64 miri64 added the OS: FreeBSD Host OS: This PR/issue concerns usage of RIOT with FreeBSD as a host system label Jul 8, 2020
bergzand
bergzand approved these changes Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break things on Linux and I trust that you've properly tested this on FreeBSD

@bergzand bergzand merged commit 4c0e8e5 into RIOT-OS:master Jul 8, 2020
@miri64 miri64 deleted the tapsetup/fix/freebsd branch July 8, 2020 09:33
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 8, 2020

Thanks for the quick review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergzand bergzand bergzand approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees

No one assigned

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs OS: FreeBSD Host OS: This PR/issue concerns usage of RIOT with FreeBSD as a host system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @bergzand