Skip to content

boards/efm32-based: Model features in Kconfig#14310

Merged
cgundogan merged 18 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/efm32_boards_symbols
Jun 19, 2020
Merged

boards/efm32-based: Model features in Kconfig#14310
cgundogan merged 18 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/efm32_boards_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jun 18, 2020

Contribution description

This models in Kconfig all the features of the efm32-based boards:

  • ikea-tradfri
  • slstk3401a
  • slstk3402a
  • sltb001a
  • slwstk6000b-slwrb4150a
  • slwstk6000b-slwrb4162a
  • stk3600
  • stk3700

Testing procedure

  • Check the symbol organization
  • Green CI
  • tests/kconfig_features should pass for all boards

Issues/PRs references

Part of #14148

@leandrolanzieri
cpu/efm32/efm32gg: Add Kconfig symbols
4f3ec84
@leandrolanzieri
cpu/efm32/efm32lg: Add Kconfig symbols
45c6d27
@leandrolanzieri
cpu/efm32/efm32pg12b: Add Kconfig symbols
777571a
@leandrolanzieri
cpu/efm32/efm32pg1b: Add Kconfig symbols
89342b3
@leandrolanzieri
cpu/efm32/efr32mg12p: Add Kconfig symbols
d578adf
@leandrolanzieri
cpu/efm32/efr32mg1p: Add Kconfig symbols
bb021f9
@leandrolanzieri
cpu/efm32: Add Kconfig symbols
8cc1fa4
@leandrolanzieri
boards/common/silabs: Add Kconfig symbols
59d2a65
@leandrolanzieri
boards/common/slwstk6000b: Add Kconfig symbols
99822f3
@leandrolanzieri
boards/ikea-tradfri: Add Kconfig symbols
00fee0e
@leandrolanzieri
boards/slstk3401a: Add Kconfig symbols
9e170e9
@leandrolanzieri
boards/slstk3402a: Add Kconfig symbols
a7b9017
@leandrolanzieri
boards/sltb001a: Add Kconfig symbols
d1d6bdb
@leandrolanzieri
boards/slwstk6000b-slwrb4150a: Add Kconfig symbols
29ee15b
@leandrolanzieri
boards/slwstk6000b-slwrb4162a: Add Kconfig symbols
0e98d1c
@leandrolanzieri
boards/stk3600: Add Kconfig symbols
badd0e8
@leandrolanzieri
boards/stk3700: Add Kconfig symbols
f99af10
@leandrolanzieri
tests/kconfig_features: Add efm32-based boards to whitelist
a2e06df
@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 18, 2020
@jia200x jia200x mentioned this pull request Jun 18, 2020
Closed
@basilfx basilfx added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 18, 2020
@basilfx
Copy link
Copy Markdown
Member

basilfx commented Jun 18, 2020

@leandrolanzieri I guess that there is not much to test, except that it passes CI?

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 19, 2020

@leandrolanzieri I guess that there is not much to test, except that it passes CI?

Yes, that and that the symbol organization makes sense. In this case it was pretty straightforward because the CPUs are nicely organized in families (thanks for that :)

@basilfx
Copy link
Copy Markdown
Member

basilfx commented Jun 19, 2020

Should the modules like USEMODULE += silabs_aem also be in there? I do see USEMODULE += boards_common_silabs though.

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 19, 2020

Should the modules like USEMODULE += silabs_aem also be in there? I do see USEMODULE += boards_common_silabs though.

No, this is only to model features. BOARD_COMMON_SILABS is a symbol to provide the common features, it is not related with the module boards_common_silabs.

@basilfx
Copy link
Copy Markdown
Member

basilfx commented Jun 19, 2020

That makes sense. Thanks for explaining.

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 19, 2020
cgundogan
cgundogan approved these changes Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also took a secondary look and the diff seems to be fine. Murdock also passes the tests. ACK

@cgundogan cgundogan merged commit 209248f into RIOT-OS:master Jun 19, 2020
@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 19, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 19, 2020

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig/efm32_boards_symbols branch June 19, 2020 13:22
@aabadie aabadie mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgundogan cgundogan cgundogan approved these changes

@basilfx basilfx basilfx approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@leandrolanzieri @basilfx @cgundogan