cpu/sam0_common: UART: implement inverted RX & TX#14300
Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom Jun 17, 2020
Merged
cpu/sam0_common: UART: implement inverted RX & TX#14300fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
Type: new feature
The UART TX and TX lines on SAMD5x and SAML1x can be inverted. However, the flags don't do exactly what one would expect. See errata 2.18.5: SERCOM-UART: TXINV and RXINV Bits Reference: > The TXINV and RXINV bits in the CTRLA register have inverted functionality. > > Workaround: > In software interpret the TXINV bit as a functionality of RXINV, and conversely, > interpret the RXINV bit as a functionality of TXINV.
benpicco
force-pushed
the
cpu/sam0_common/uart_txinv
branch
from
0c0569e to
585dc15
Compare
benpicco
added
the
CI: ready for build
fjmolinas
reviewed
Jun 17, 2020
fjmolinas
approved these changes
Jun 17, 2020
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
I don't have a BOARD supporting this functionality, but implementation matches the datasheet and errata. ACK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The UART TX and TX lines on SAMD5x and SAML1x can be inverted.
However, the flags don't do exactly what one would expect.
See errata 2.18.5: SERCOM-UART: TXINV and RXINV Bits Reference:
Testing procedure
Issues/PRs references