cpu/stm32: don't include usbdev_stm32.h in periph_cpu_common.h#14174
Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom Jun 2, 2020
Merged
cpu/stm32: don't include usbdev_stm32.h in periph_cpu_common.h#14174bergzand merged 1 commit intoRIOT-OS:masterfrom
bergzand merged 1 commit intoRIOT-OS:masterfrom
Conversation
`usbdev_stm32.h` will pull in `usb.h` which causes an error if `USB_H_USER_IS_RIOT_INTERNAL` is not set. Turns out this include is not needed, so just drop it.
benpicco
added
Type: bug
benpicco
requested review from
DipSwitch,
aabadie,
fjmolinas and
vincent-d
as code owners
Contributor
|
If murdock is happy this change should be Ok, I still had a look at the different configurations to see they where not needed there. Maybe @bergzand can give ti a quick test? |
Member
|
With the nucleo-f446ze as target, the binary generated with this PR matches the binary generated without this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
usbdev_stm32.hwill pull inusb.hwhich causes an error for each file that includesperiph_cpu_common.hbut does not setUSB_H_USER_IS_RIOT_INTERNAL.Turns out this include is not needed, so just drop it.
This will make working with (currently out-of-tree) stm32 boards that use CDC ACM for stdio possible.
Testing procedure
Enable
stdio_cdc_acmon any stm32 boardIssues/PRs references
split off #14122, #12778 & #13382