Skip to content

cc26xx_cc13xx: add periph_i2c implementation#14128

Merged
benpicco merged 4 commits intoRIOT-OS:masterfrom
btcven:2020_05_24-cc13x2-i2c
May 25, 2020
Merged

cc26xx_cc13xx: add periph_i2c implementation#14128
benpicco merged 4 commits intoRIOT-OS:masterfrom
btcven:2020_05_24-cc13x2-i2c

Conversation

@jeandudey
Copy link
Copy Markdown
Contributor

@jeandudey jeandudey commented May 24, 2020

Contribution description

The CC26xx/CC13xx MCUs have only a single I2C interface, and has not changed between x0/x2 revisions, it's exactly the same (the SDK is using the same exact code).

Only 100 kbit/s mode is supported, fast mode (400 kbit/s) is up to another PR.

Testing procedure

  • cc26x0 boards should still have a working I2C (no code is touched in reality).
  • cc26x2/cc13x2 boards should be able to run tests/periph_i2c correctly with a known working device. Please note that this device has weak pull-up resistors.

Issues/PRs references

#13635

cc @luisan00, could you check if the pins for CC1352P launchpad are good?

@luisan00
Copy link
Copy Markdown
Contributor

cc @luisan00, could you check if the pins for CC1352P launchpad are good?

Sure @jeandudey

@jeandudey jeandudey force-pushed the 2020_05_24-cc13x2-i2c branch from 5804af1 to 85a2232 Compare May 24, 2020 18:15
@benpicco benpicco added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT labels May 24, 2020
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moves the driver to a common place.
If @luisan00 confirms the pin numbers are allright, this should be good.

@luisan00
Copy link
Copy Markdown
Contributor

luisan00 commented May 25, 2020

Hi! I was testing the CC1352P Launchpad and I2C pins are good. 👍

> i2c_read_reg 0 85 6 0
2
2020-05-25 21:58:04,759 #  i2c_read_reg 0 85 6 0
3
2020-05-25 21:58:04,763 # Command: i2c_read_reg(0, 0x55, 0x06, 0x00)
4
2020-05-25 21:58:04,768 # Success: i2c_0 read 1 byte(s) from reg 0x06 : [0xa8]

@benpicco @jeandudey

@benpicco benpicco merged commit a5836a6 into RIOT-OS:master May 25, 2020
@jeandudey jeandudey deleted the 2020_05_24-cc13x2-i2c branch May 25, 2020 22:01
@jeandudey
Copy link
Copy Markdown
Contributor Author

Thanks for the review and time dedicated!

@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants