Skip to content

boards/common/blxxxpill: provide periph_rtt#13929

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_rtt_blxxpill
Apr 24, 2020
Merged

boards/common/blxxxpill: provide periph_rtt#13929
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_rtt_blxxpill

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Apr 23, 2020

Contribution description

blxxpill share the same periph_conf and they all have CLOCK_LSE, periph_rtt should work on them.

Testing procedure

I don't have a blxxxpill but verify:

BOARD=<blxxxpill> make -C tests/peripsh_rtt flash test

Issues/PRs references

Based on #13907

@fjmolinas fjmolinas added Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first Area: boards Area: Board ports labels Apr 23, 2020
@fjmolinas fjmolinas mentioned this pull request Apr 23, 2020
Merged
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Apr 23, 2020

Waiting for #13907 t get merged.

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Apr 23, 2020

The test passes, tested on bluepill:

Welcome to pyterm!
Type '/exit' to exit.
READY
s
START
main(): This is RIOT! (Version: 2020.07-devel-110-g7a42d-pr_rtt_blxxpill)

RIOT RTT low-level driver test
This test will display 'Hello' every 5 seconds

Initializing the RTT driver
RTT now: 0
Setting initial alarm to now + 5 s (81920)
Done setting up the RTT, wait for many Hellos
Hello
Hello
Hello
Hello
Hello

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Apr 24, 2020
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Apr 24, 2020

All green @leandrolanzieri

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 24, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Apr 24, 2020

Test still works:

Type '/exit' to exit.
READY
s
START
main(): This is RIOT! (Version: 2020.07-devel-188-ga72ab-pr_rtt_blxxpill)

RIOT RTT low-level driver test
This test will display 'Hello' every 5 seconds

Initializing the RTT driver
RTT now: 0
Setting initial alarm to now + 5 s (81920)
Done setting up the RTT, wait for many Hellos
Hello
Hello
Hello
Hello
Hello

make: Leaving directory '/home/leandro/Work/RIOT/tests/periph_rtt'

leandrolanzieri
leandrolanzieri approved these changes Apr 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@leandrolanzieri leandrolanzieri merged commit 0beb48a into RIOT-OS:master Apr 24, 2020
@fjmolinas fjmolinas deleted the pr_rtt_blxxpill branch May 5, 2020 14:47
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented May 5, 2020

Thanks for the review!

@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@vincent-d vincent-d Awaiting requested review from vincent-d

Assignees

No one assigned

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@fjmolinas @leandrolanzieri @miri64