sys/uri_parser: check for uri_end instead of 0#13789
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Apr 3, 2020
Merged
Conversation
cgundogan
added
Type: bug
cgundogan
force-pushed
the
pr/uri_parser/remove_check_for_zero
branch
from
c5f0b42 to
9b2f7bc
Compare
Member
Author
|
added a test that fails on master and works with the patch |
cgundogan
changed the title
miri64
requested changes
Apr 2, 2020
cgundogan
force-pushed
the
pr/uri_parser/remove_check_for_zero
branch
from
9b2f7bc to
1bfc1fb
Compare
Member
Author
|
@miri64 addressed your comments and amended immediately. Looks much nicer with |
miri64
added
CI: ready for build
cgundogan
added
CI: ready for build
Member
Author
|
retriggered murdock because of a test timeout |
Member
Author
|
murdock agrees now |
miri64
approved these changes
Apr 3, 2020
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
ACK! In addition to the tests running on the CI, I ran tests-uri_parse alone on a samr21-xpro. They pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Since we also allow the use of non-\0-terminated strings, we have to remove this check here. Otherwise, it returns-1for those strings, although parsing was successful.The check was overcautious anyway.
I changed the diff now to check for
uri_endinstead of completely removing it.Testing procedure
unittests should still run
Issues/PRs references
none