Skip to content

Makefile.dep: add auto_init_usbus as usbus DEFAULT_MODULE#13703

Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_usbus_autoinit
Mar 25, 2020
Merged

Makefile.dep: add auto_init_usbus as usbus DEFAULT_MODULE#13703
bergzand merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_usbus_autoinit

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

Contribution description

This PR adds auto_init_usbus as a default module when usbus is used.

Testing procedure

No change in USEMODULES:

  • boards_common_samd21-arduino-bootloader users:
BOARD=arduino-mkrfox1200 make -C examples/hello-world/ info-debug-variable-USEMODULE --no-print-directory | grep auto_init_usbus
auto_init auto_init_usbus board boards_common_arduino-mkr boards_common_samd21-arduino-bootloader core core_init core_msg core_panic core_thread_flags cortexm_common cortexm_common_periph cpu event isrpipe newlib newlib_nano newlib_syscalls_default periph periph_common periph_gpio periph_init periph_init_common periph_init_gpio periph_init_init periph_init_pm periph_init_usbdev periph_pm periph_usbdev pm_layered sam0_common_periph stdio_cdc_acm sys tsrb usb_board_reset usbus usbus_cdc_acm
  • tests/usbus_cdc_ecm/
make -C tests/usbus_cdc_ecm/ info-debug-variable-USEMODULE --no-print-directory | grep auto_init_usbus
auto_init auto_init_gnrc_ipv6 auto_init_gnrc_ipv6_nib auto_init_gnrc_netif auto_init_gnrc_pktbuf auto_init_random auto_init_usbus auto_init_xtimer board core core_init core_msg core_panic core_thread_flags cortexm_common cortexm_common_periph cpu div event evtimer fmt gnrc gnrc_icmpv6 gnrc_icmpv6_echo gnrc_ipv6 gnrc_ipv6_hdr gnrc_ipv6_nib gnrc_ipv6_nib_router gnrc_ipv6_router gnrc_ipv6_router_default gnrc_ndp gnrc_netapi gnrc_netif gnrc_netif_ethernet gnrc_netif_hdr gnrc_netif_init_devs gnrc_netreg gnrc_pkt gnrc_pktbuf gnrc_pktbuf_static icmpv6 inet_csum iolist ipv6_addr ipv6_hdr isrpipe l2util luid netdev_eth netif newlib newlib_nano newlib_syscalls_default periph periph_common periph_cpuid periph_gpio periph_init periph_init_common periph_init_cpuid periph_init_gpio periph_init_init periph_init_pm periph_init_timer periph_init_uart periph_init_usbdev periph_pm periph_timer periph_uart periph_usbdev pm_layered prng prng_tinymt32 ps random sam0_common_periph shell shell_commands stdin stdio_uart stdio_uart_rx sys tinymt32 tsrb usbus usbus_cdc_ecm xtimer
  • tests/usbus_cdc_acm_stdio/
make -C tests/usbus_cdc_acm_stdio/ info-debug-variable-USEMODULE --no-print-directory | grep auto_init_usbus
auto_init auto_init_usbus board core core_init core_msg core_panic core_thread_flags cortexm_common cortexm_common_periph cpu event isrpipe newlib newlib_nano newlib_syscalls_default periph periph_common periph_gpio periph_init periph_init_common periph_init_gpio periph_init_init periph_init_pm periph_init_usbdev periph_pm periph_usbdev pm_layered ps sam0_common_periph shell shell_commands stdin stdio_cdc_acm sys tsrb usbus usbus_cdc_acm
  • can be disabled if requires
DISABLE_MODULE=auto_init_usbus make -C tests/usbus_cdc_acm_stdio/ info-debug-variable-USEMODULE --no-print-directory | grep auto_init_usbus
#empty

@fjmolinas fjmolinas added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: USB Area: Universal Serial Bus labels Mar 24, 2020
@fjmolinas fjmolinas requested review from aabadie and bergzand March 24, 2020 18:08
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 24, 2020
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense and reduces code duplication.

@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 25, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 25, 2020
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@bergzand bergzand merged commit bf2b495 into RIOT-OS:master Mar 25, 2020
@fjmolinas fjmolinas deleted the pr_usbus_autoinit branch March 25, 2020 10:08
chrysn added a commit to chrysn-pull-requests/RIOT that referenced this pull request May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants