xtimer_msg_receive_timeout: only send timeout msg if thread still waits for it#13500
Open
MichelRottleuthner wants to merge 1 commit intoRIOT-OS:masterfrom
Open
xtimer_msg_receive_timeout: only send timeout msg if thread still waits for it#13500MichelRottleuthner wants to merge 1 commit intoRIOT-OS:masterfrom
MichelRottleuthner wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
kaspar030
reviewed
Feb 28, 2020
| xtimer_t t = { .callback = _callback_timeout_msg, | ||
| .arg = &tmsg }; | ||
|
|
||
| _xtimer_set64(&t, timeout_ticks, timeout_ticks >> 32); |
Contributor
There was a problem hiding this comment.
This is now racey.
If the thread gets scheduled away after this set(), the timer triggers, then the thread gets scheduled again, it'll sit in msg_receive() forever.
Contributor
Author
There was a problem hiding this comment.
Good catch! Ok how about something like the idea I sketched in #13429 comment then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes #13345 without requiring
core_thread_flags.The idea came from @JulianHolzwarth #13345 (comment)
Testing procedure
In master the following snipped crashes, with this PR it should work.
See #13345 for further details.
Details
Issues/PRs references
Alternative to #13429.