Skip to content

gnrc_ipv6_ext_opt: initial import#13275

Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom
miri64:gnrc_ipv6_ext_opt/feat/initial
May 20, 2020
Merged

gnrc_ipv6_ext_opt: initial import#13275
benpicco merged 3 commits intoRIOT-OS:masterfrom
miri64:gnrc_ipv6_ext_opt/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 3, 2020

Contribution description

This provides header parsing for IPv6 hop-by-hop and destination options according to RFC 8200.

Testing procedure

I provided a test application using scapy:

make -C tests/gnrc_ipv6_ext_opt/ flash
sudo BOARD=samr21-xpro make -C tests/gnrc_ipv6_ext_opt/ test

Issues/PRs references

First step for a new adaptation for #7231

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 3, 2020
@miri64 miri64 requested a review from smlng February 3, 2020 17:14
@miri64 miri64 changed the title Gnrc ipv6 ext opt/feat/initial gnrc_ipv6_ext_opt: initial import Feb 3, 2020
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 3, 2020

Forgot to commit the most important part... The actual module 😅

aabadie
aabadie reviewed Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor things in this PR but haven't look in detail at the compliance of the implementation with the RFC.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 5, 2020

Addressed comments

@tcschmidt tcschmidt requested a review from kaspar030 April 1, 2020 00:58
@miri64 miri64 mentioned this pull request Apr 1, 2020
Draft
benpicco
benpicco reviewed May 10, 2020
View reviewed changes
benpicco
benpicco reviewed May 12, 2020
View reviewed changes
@benpicco benpicco requested a review from leandrolanzieri May 19, 2020 14:05
benpicco
benpicco approved these changes May 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash!
Code looks good, there are working tests and this is self-contained without affecting anything else - ACK.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 20, 2020

Squashed.

@miri64 miri64 force-pushed the gnrc_ipv6_ext_opt/feat/initial branch from 0d7eb79 to 564eb78 Compare May 20, 2020 06:53
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented May 20, 2020 •
edited
Loading

flake8 is nitpicking the Python code - just squash directly.

@miri64 miri64 force-pushed the gnrc_ipv6_ext_opt/feat/initial branch from 564eb78 to f6bd070 Compare May 20, 2020 10:34
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 20, 2020

Fixed and squashed all static test failures (not just flake8 ;-))

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 20, 2020
@benpicco benpicco merged commit 70543bb into RIOT-OS:master May 20, 2020
@miri64 miri64 deleted the gnrc_ipv6_ext_opt/feat/initial branch May 20, 2020 13:30
@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 19, 2021

What's left after this to implement non-storing mode?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 19, 2021

The hop-by-hop option needs to be implemented still.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 19, 2021

See https://github.com/miri64/RIOT/tree/gnrc_rpl_opt/feat/initial for my initial work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie left review comments

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @benpicco @aabadie