Kconfig: Expose gnrc/netif configurations#13065
Merged
leandrolanzieri merged 5 commits intoRIOT-OS:masterfrom Jan 13, 2020
Merged
Kconfig: Expose gnrc/netif configurations#13065leandrolanzieri merged 5 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 5 commits intoRIOT-OS:masterfrom
Conversation
PeterKietzmann
added
Area: network
71 tasks
leandrolanzieri
requested changes
Jan 10, 2020
Contributor
leandrolanzieri
left a comment
leandrolanzieri
left a comment
There was a problem hiding this comment.
It looks good. examples/gnrc_networking builds as usual and configurations can be changed via Kconfig.
Just one comment: you skipped two occurrences of GNRC_NETIF_IPV6_ADDRS_NUMOF:
tests/gnrc_sock_dns/Makefile:34examples/gnrc_minimal/Makefile:27
leandrolanzieri
added
Reviewed: 1-fundamentals
PeterKietzmann
force-pushed
the
pr_kconf_netif
branch
from
a007a0c to
b966ec2
Compare
Member
Author
|
@leandrolanzieri thanks for the review. I addressed your comments. |
leandrolanzieri
added
the
CI: ready for build
Contributor
|
The message for b966ec2 seems to be too long 😕 |
PeterKietzmann
force-pushed
the
pr_kconf_netif
branch
2 times, most recently
from
4debfca to
cce97a0
Compare
miri64
reviewed
Jan 10, 2020
PeterKietzmann
force-pushed
the
pr_kconf_netif
branch
from
cce97a0 to
0e951fa
Compare
leandrolanzieri
added
the
Reviewed: 3-testing
PeterKietzmann
force-pushed
the
pr_kconf_netif
branch
from
0e951fa to
fb71ccc
Compare
leandrolanzieri
approved these changes
Jan 13, 2020
Contributor
leandrolanzieri
left a comment
leandrolanzieri
left a comment
There was a problem hiding this comment.
I did a few greps and all macros appear to be changed now (with the correct prefix). ACK!
This was referenced Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR moves the configuration macros of
gnrc_netiffound here to theCONFIG_namespace, and exposes them to Kconfig.As agreed offline with @leandrolanzieri I did not include the default thread priority parameter because this should be defined by the platform, if not changed manually. We might need a better solution to this in future.
Furthermore, I did not include
GNRC_NETIF_NUMOFbecause this won't be static anymore in the future.Testing procedure
examples/gnrc_networkingshould still work as usual.make menuconfigin the test application.Issues/PRs references
Part of #12888