cpu/esp*: esp_wifi used as default netdev for lwip#13004
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jan 11, 2020
Merged
cpu/esp*: esp_wifi used as default netdev for lwip#13004benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
Area: network
gschorcht
added
CI: ready for build
Contributor
Author
|
@benpicco Thanks for setting the labels. I just forgot it because of the limited time I have on my holiday trip.. |
gschorcht
added
the
Platform: ESP
benpicco
approved these changes
Jan 10, 2020
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks good.
I'd suggest moving that entire block to esp_common/Makefile.include though.
Duplicate code blocks like this will just get out-of sync eventually and there is nothing esp32/8266 specific here.
Contributor
Author
Yeah. It's just an interim solution. There is already PR #12955 with complete code deduplication where it will be in |
Contributor
Author
|
Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
With this PR,
esp-wifiis defined as default network device forpkg/lwip.Normally,
esp_nowis used as the default network device for ESP modules. However,esp_nowcannot be used together withpkg/lwip. Therefore,esp_wifiis used instead as the default network device if modulelwipis enabled.Testing procedure
Flash
tests/lwipto any ESP32 and any ESP8266 board and ping the nodes from any machine in the LAN.Issues/PRs references