pkg/lwip: add support for esp32 Ethernet device#12950
Merged
benpicco merged 5 commits intoRIOT-OS:masterfrom Dec 16, 2019
Merged
pkg/lwip: add support for esp32 Ethernet device#12950benpicco merged 5 commits intoRIOT-OS:masterfrom
benpicco merged 5 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
added
Area: pkg
benpicco
approved these changes
Dec 15, 2019
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks good, just follows the same pattern contrib/lwip.c.
benpicco
reviewed
Dec 15, 2019
Contributor
|
Please squash! |
gschorcht
force-pushed
the
cpu/esp32/lwip_eth
branch
from
4412995 to
91e764a
Compare
Contributor
Author
|
@benpicco Squashed. |
Contributor
Author
|
Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds the support for ESP32 Ethernet device to
pkg/lwipin same way as PR #12895 does. Addititionally, it adds the IPv4 support for the ESP32 Ethernet device as PR #12903.Testing procedure
Flash
tests/lwipwith enabled moduleesp_wifion any ESP32 board with an Ethernet interface (for example Olimex ESP32-EVB)and execute
ifconfigon ESP32 node and ping the node from any machine in the LAN.Issues/PRs references
Related to PR #12903.