boards/hifive1b: add arduino feature#12902
Merged
fjmolinas merged 2 commits intoRIOT-OS:masterfrom Dec 16, 2019
Merged
Conversation
aabadie
added
Type: new feature
fjmolinas
reviewed
Dec 13, 2019
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Arduino mappings look good, just minor nitpicking. Could explain a little more why the second commit is needed?
aabadie
force-pushed
the
pr/boards/hifive1b_arduino
branch
from
c36a65e to
9aa8166
Compare
This ensures the ARRAY_SIZE macro is implicitly available
aabadie
force-pushed
the
pr/boards/hifive1b_arduino
branch
from
82c118b to
b49cca2
Compare
Contributor
Author
|
Comments addressed @fjmolinas. |
Contributor
Author
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is adding the Arduino feature to the hifive1b board.
It also does a minor cleanup in cpu.h/periph_cpu.h/cpu.c with isr functions declaration and includes. This fixes some compilation issues about ARRAY_SIZE is not defined.
Testing procedure
make BOARD=hifive1b -C tests/sys_arduino flash testshould work when used with tools/testrunner: make interactive test sync retries/delay configurable #12891.Issues/PRs references
None