Merged
Conversation
benpicco
reviewed
Dec 6, 2019
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks pretty straightforward, just two minor coding style nits.
miri64
added
Area: network
Fix minor coding style issues
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Dec 6, 2019
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Small addition, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Add glue code to initialize Ethernet and add netif for stm32 in lwip_bootstrap.
LWIP now supports STM32.
Testing procedure
Before:
tests/lwip --> send_ip() --> fails, because there is no available netif
After:
tests/lwip --> send_ip() --> works