Skip to content

drivers/bmx280: add temp_measurement to methods#12772

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
daexel:bme280_bugfix
Nov 25, 2019
Merged

drivers/bmx280: add temp_measurement to methods#12772
benpicco merged 1 commit intoRIOT-OS:masterfrom
daexel:bme280_bugfix

Conversation

@daexel
Copy link
Copy Markdown
Contributor

@daexel daexel commented Nov 21, 2019 •
edited
Loading

Contribution description

This PR is providing a bugfix for humidity and pressure measurement. The variable t_fine is used in pressure and humidity compensation formulas. So you must read the sensor and calculate the temperature before calculate current humidity or pressure.

  • Add the method bmx280_read_temperature to humidity and pressure measurement.

Testing procedure

Issues/PRs references

@benpicco benpicco added Area: drivers Area: Device drivers Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 21, 2019
@benpicco benpicco changed the title add temp_measurement to methods drivers/bmx280: add temp_measurement to methods Nov 21, 2019
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Nov 21, 2019

Does #8383 work for you or does it also need this fix?

@daexel
Copy link
Copy Markdown
Contributor Author

daexel commented Nov 22, 2019

No that fix is not included in #8383

@benpicco benpicco mentioned this pull request Nov 22, 2019
Merged
@haukepetersen haukepetersen added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines labels Nov 22, 2019
@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Nov 22, 2019

ACK for the change, nice catch!

I would propose we get #8383 merged and put this PR right on top. @daexel sounds good?

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Nov 24, 2019

Then this one needs a rebase.

@daexel daexel force-pushed the bme280_bugfix branch 2 times, most recently from f332e18 to 6468461 Compare November 25, 2019 10:42
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 25, 2019
kaspar030
kaspar030 reviewed Nov 25, 2019
View reviewed changes
haukepetersen
haukepetersen approved these changes Nov 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. However, I did not test it, so that maybe someone else can verify this?!

@haukepetersen haukepetersen added Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 25, 2019
@daexel
Copy link
Copy Markdown
Contributor Author

daexel commented Nov 25, 2019

Bildschirmfoto vom 2019-11-25 16-26-48

@benpicco benpicco merged commit af0c6e9 into RIOT-OS:master Nov 25, 2019
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 left review comments

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

5 participants

@daexel @benpicco @haukepetersen @kaspar030 @fjmolinas