Skip to content

RIOT: fix PEP8 errors#12706

Merged
aabadie merged 4 commits intoRIOT-OS:masterfrom
fjmolinas:pr_fix_flake8
Nov 23, 2019
Merged

RIOT: fix PEP8 errors#12706
aabadie merged 4 commits intoRIOT-OS:masterfrom
fjmolinas:pr_fix_flake8

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Nov 14, 2019

Contribution description

There are some PEP8 still present in the code base, this PR removes them.

Testing procedure

In master running ./dist/tools/flake8/check.sh will list multiple issues, non with this PR.

Issues/PRs references

Depends on #12687 that fixes libfixmath pep8 errors.

@fjmolinas fjmolinas added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Nov 14, 2019
@fjmolinas fjmolinas requested a review from aabadie November 14, 2019 10:48
miri64
miri64 reviewed Nov 14, 2019
View reviewed changes
Comment thread tests/libfixmath/do-test.py
@miri64 miri64 mentioned this pull request Nov 14, 2019
Merged
@fjmolinas fjmolinas removed the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 21, 2019
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 21, 2019
@fjmolinas fjmolinas requested review from aabadie and removed request for aabadie November 21, 2019 09:15
aabadie
aabadie requested changes Nov 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some uses of expect functions are just expecting plain string, without any regex, so I think some uses of r could just be replaced with expect_exact. See below (my suggestions are untested ;) ).

Comment thread tests/thread_msg_seq/tests/01-run.py Outdated
Comment thread tests/pkg_fatfs_vfs/tests/01-run.py Outdated
Comment thread tests/mutex_order/tests/01-run.py Outdated
Comment thread tests/msg_try_receive/tests/01-run.py Outdated
Comment thread tests/lwip/tests/01-run.py Outdated
Comment thread tests/cond_order/tests/01-run.py Outdated
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Nov 22, 2019

Some uses of expect functions are just expecting plain string, without any regex, so I think some uses of r could just be replaced with expect_exact. See below (my suggestions are untested ;) ).

Makes sense, can I squash directly?

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Nov 22, 2019

Makes sense, can I squash directly?

Go ahead

@aabadie aabadie added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 22, 2019
aabadie
aabadie approved these changes Nov 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green after a full CI run tests (with cache disabled).

ACK and go!

@aabadie aabadie merged commit 8a76acf into RIOT-OS:master Nov 23, 2019
@fjmolinas fjmolinas deleted the pr_fix_flake8 branch December 1, 2019 14:17
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 left review comments

@aabadie aabadie aabadie approved these changes

Assignees

No one assigned

Labels

CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

4 participants

@fjmolinas @aabadie @miri64 @1962707