Merged
Conversation
leandrolanzieri
added
Type: new feature
leandrolanzieri
requested review from
aabadie,
cgundogan,
fjmolinas and
jia200x
leandrolanzieri
force-pushed
the
pr/dist/tools/add_kconfiglib
branch
from
f169350 to
1f9a32a
Compare
Kconfiglib is a Kconfig implementation in Python 2/3. See https://github.com/ulfalizer/Kconfiglib
leandrolanzieri
force-pushed
the
pr/dist/tools/add_kconfiglib
branch
from
1f9a32a to
b642f2e
Compare
Member
|
@RIOT-OS/maintainers please have a look on this PR ;) |
cgundogan
approved these changes
Nov 21, 2019
Member
cgundogan
left a comment
cgundogan
left a comment
There was a problem hiding this comment.
The proposed change is unintrusive. Tested with the patch file that @leandrolanzieri provided in the original post. ACK
Contributor
|
Tested and passed! |
Contributor
|
Should we merge this without it being used? |
Contributor
Author
@kaspar030 I've added a PR with the integration of Kconfig into the build system (#12773) |
Member
|
@miri64 as you've been asked: Anything you want to comment on this rather trivial PR? Otherwise I think this can be completed. |
tcschmidt
added
the
CI: ready for build
Member
|
Not sure why I was asked though. There is a PR that uses this. So I don't see why it shouldn't be merged as a dependency. If Kconfig proofs to be a dead-end we can always remove it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds Kconfiglib to our tools, as a package. Kconfiglib is a Kconfig implementation in Python 2/3.
It can run standalone, but also includes some tools already implemented (e.g. menuconfig or genconfig, which are copied from the package in this PR). This has the advantage that we can handle Kconfig files using Python scripts (such as generating Doxygen documentation for all compile-time options).
Testing procedure
You can apply this patch and run
make test-tool -C examples/default. It should download the package and check that the files were copied, printingPASSif everything went as expected.Issues/PRs references
None so far