gnrc_sixlowpan_frag: factor-out and rename fragmentation buffer#12559
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Nov 7, 2019
Merged
Conversation
miri64
added
Area: network
benpicco
added
the
CI: ready for build
miri64
force-pushed
the
gnrc_sixlowpan_frag/enh/factor-out-frag-buf
branch
from
54e2715 to
87f7769
Compare
Member
Author
|
Rebased to current master. |
miri64
force-pushed
the
gnrc_sixlowpan_frag/enh/factor-out-frag-buf
branch
from
7ede405 to
ddf9354
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 31, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 4, 2019
The name `fragment_msg` or `frag_msg`/`msg_frag` always to me was a bit misplaced, as it basically implements an asynchronous fragmentation buffer and doesn't necessarily have anything to do with messages. This change 1. changes the name to `fb` (for fragmentation buffer) 2. factors its code out to its own sub-module so it can be re-used by other 6LoWPAN fragmentation schemes like [Selective Fragment Recovery] [Selective Fragment Recovery]: https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-05
miri64
force-pushed
the
gnrc_sixlowpan_frag/enh/factor-out-frag-buf
branch
from
d270331 to
ca37cde
Compare
Member
Author
|
Rebased to current master |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 5, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 6, 2019
benpicco
approved these changes
Nov 7, 2019
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
This really just renames and moves code around.
No functional changes expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The name
fragment_msgorfrag_msg/msg_fragalways to me was a bit misplaced, as it basically implements an asynchronous fragmentation buffer and doesn't necessarily have anything to do with messages. This changefb(for fragmentation buffer)Testing procedure
still works (I tested on
nativeandsamr21-xpro) and pinging large (>100 bytes) packets between two nodes using 6LoWPAN (e.g.iotlab-m3) withexamples/gnrc_networkingstill works and shows comparable performance to master (tested in the IoT-LAB in my case).In this PR:
On master:
Issues/PRs references
None