pkg/tinycbor: fix of compiler warnings "uninitialized variable used"#12505
pkg/tinycbor: fix of compiler warnings "uninitialized variable used"#12505benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
gschorcht
added
Area: pkg
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Small change, just fixes a compiler warning at the cost of an additional instruction.
Can you also submit a PR to https://github.com/intel/tinycbor while you're at it, so we can drop this patch in the future.
On ESP32 and new ESP8266 platform, the compilation of the package fails since a local variable is potentially used uninitialized. Therefore, the variable is initialized with a default value.
gschorcht
force-pushed
the
pkg/tinycbor/compilation_fix
branch
from
2cca1e5 to
b6b1252
Compare
|
It's all green, feel free to press the button 😉 |
@benpicco It's a bad style to merge own PRs. This should always be done by a reviewer or at least by another maintainer. |
That feels like unnecessary friction. If you want to adhere to that, the maintainer would have to go through all PRs again after they already ACKed them, just to see if CI has finished running. I see that it would be a bad idea to merge if there is still an ongoing discussion, but when you got an uncontested ACK you are free to merge IMHO. |
|
Thanks. |
3 participants
Contribution description
This PR patches the
tinycborpackage. On ESP32 and new ESP8266 (PR #11108) platforms, the compilation of the package fails since a local variable is potentially used uninitialized:With the patch provided in this PR, the variable is initialized with a default value and the according boards are removed from the balcklist.
Testing procedure
Just try to compile
tests/tinycborfor a ESP32 board:Issues/PRs references
Required for PR #11108