Skip to content

cpu: mips*: Reorganize headers#12477

Merged
benpicco merged 5 commits intoRIOT-OS:masterfrom
francois-berder:mips-refactor
Oct 21, 2019
Merged

cpu: mips*: Reorganize headers#12477
benpicco merged 5 commits intoRIOT-OS:masterfrom
francois-berder:mips-refactor

Conversation

@francois-berder
Copy link
Copy Markdown
Contributor

Contribution description

Reorganize headers in cpu/mips32r2_common, cpu/mips_pic32_common, cpu/mips_pic32mx and cpu/mips_pic32mzto make it more similar to other cpu architectures.

Testing procedure

This PR does not introduce any new features so hopefully everything should continue working.
Compile hello-world and check that the UART output is correct.

Issues/PRs references

None.

@benpicco benpicco added Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 17, 2019
@benpicco
Copy link
Copy Markdown
Contributor

Murdock found some doxygen issues.
Otherwise this looks good.

@francois-berder
Copy link
Copy Markdown
Contributor Author

Murdock fails because my PR needs squashing. Apart from that, the doxygen warnings were fixed and the PR is ready for review.

@benpicco
Copy link
Copy Markdown
Contributor

Go ahead and squash then!

Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only moves code around.
Murdock run should be enough.

@benpicco benpicco merged commit 80c0033 into RIOT-OS:master Oct 21, 2019
@francois-berder francois-berder deleted the mips-refactor branch October 24, 2019 18:03
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants