Skip to content

boards/frdm: update openocd version requirements#12470

Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/boards/kw41z_openocd
Oct 21, 2019
Merged

boards/frdm: update openocd version requirements#12470
aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/boards/kw41z_openocd

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Oct 16, 2019

Contribution description

This PR drops the Makefile.include code and OpenOCD config related to older versions of OpenOCD (<0.10) for the NXP FRDM boards.

It also document the need for a built from source and more recent version of OpenOCD for KW41Z CPU models.

Testing procedure

The following command should work with an OpenOCD version >= 0.10:

$ make BOARD=frdm-k64f -C examples/hello-world flash

The following command should work with a built from OpenOCD version that is earlier than openocd-org/openocd@2c8602e:

$ make BOARD=frdm-kw41z -C examples/hello-world flash
$ make BOARD=usb-kw41z -C examples/hello-world flash

Issues/PRs references

fixes #10857 (according to #10857 (comment), only the doc is missing and this is added by 4c794c1)

@aabadie
boards/frdm: remove OpenOCD < 0.10 specific code
f81baf2 
OpenOCD 0.10 is out from early 2017, all stable Linux distros provide this version now.
@aabadie
boards/frdm: document more the OpenOCD version requirement
4c794c1 
Add the need to have a built from source version of OpenOCD for kw41z and give the url of the commit adding the change in OpenOCD
@aabadie aabadie added Area: doc Area: Documentation Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Oct 16, 2019
@aabadie aabadie requested a review from fjmolinas October 16, 2019 13:01
fjmolinas
fjmolinas reviewed Oct 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change. I verified that stables distros do indeed have 0.10.

Might people with old raspbian not have it though? Thinking of our hil setups?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Oct 18, 2019

Might people with old raspbian not have it though? Thinking of our hil setups?

CC'ing @MrKevinWeiss then.

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Oct 21, 2019

Thanks for the heads up. Let me run it!

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Oct 21, 2019

Running on HiL

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Oct 21, 2019

So far it looks like flash on the frdm-kw41 and frdm-k22f are passing... It also seems like we are using the 0.10.0 openOCD version.

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Oct 21, 2019

So far it looks like flash on the frdm-kw41 and frdm-k22f are passing... It also seems like we are using the 0.10.0 openOCD version.

What distribution are you using?

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Oct 21, 2019 

PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

But we use ansible to compile openOCD from sources I think (this is more a @smlng thing):

openocd -v
Open On-Chip Debugger 0.10.0+dev-00925-g08195413 (2019-08-29-11:22)

@smlng
Copy link
Copy Markdown
Member

smlng commented Oct 21, 2019

yes we compile openocd from source, which include the respective commit for kw41z by @gebart

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Oct 21, 2019

yes we compile openocd from source, which include the respective commit for kw41z

Thanks @smlng. So I guess we are good here.

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Oct 21, 2019

Thanks @smlng. So I guess we are good here.

Yep, ACK!

fjmolinas
fjmolinas approved these changes Oct 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@aabadie aabadie merged commit 4b06a11 into RIOT-OS:master Oct 21, 2019
@aabadie aabadie deleted the pr/boards/kw41z_openocd branch October 21, 2019 11:30
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

frdm-kw41z: requires newer flasher than openocd 0.10 from ubuntu-bionic.

4 participants

@aabadie @MrKevinWeiss @fjmolinas @smlng